how to sign eip-1559 transaction?

[adatoshima]

I'm using ethers-5.4.esm.min.js to sign tx object to raw transactions.
It's ok with old type tx.
When I sign eip-1559 tx I get error: invalid object key - maxFeePerGas
the code:

wallet=new Wallet(privateKey)
tx={
    chainId: 1,
    nonce: 0,
    gasLimit: 21000,
    to: '0x0000000000000000000000000000000000000000',
    value: 0,
    maxFeePerGas: 2e9,
    maxPriorityFeePerGas: 200e9,
  }
console.log(await wallet.signTransaction(tx))

error:

Uncaught Error: invalid object key - maxFeePerGas (argument="transaction:maxFeePerGas", value={"chainId":1,"nonce":0,"gasLimit":21000,"to":"0x0000000000000000000000000000000000000000","value":0,"maxFeePerGas":2000000000,"maxPriorityFeePerGas":200000000000}, code=INVALID_ARGUMENT, version=properties/5.4.1)
    at Logger.makeError (ethers-5.4.esm.min.js:1)
    at Logger.throwError (ethers-5.4.esm.min.js:1)
    at Logger.throwArgumentError (ethers-5.4.esm.min.js:1)
    at ethers-5.4.esm.min.js:1
    at Array.forEach (<anonymous>)
    at checkProperties (ethers-5.4.esm.min.js:1)
    at _serialize (ethers-5.4.esm.min.js:1)
    at serialize (ethers-5.4.esm.min.js:1)
    at ethers-5.4.esm.min.js:1
    at async <anonymous>:1:13

any help?

Thanks in advance.

[zemse]

@adatoshima You just need to include an extra key to the tx object type: 2,

tx={
    type: 2,
    chainId: 1,
    nonce: 0,
    gasLimit: 21000,
    to: '0x0000000000000000000000000000000000000000',
    value: 0,
    maxFeePerGas: 2e9,
    maxPriorityFeePerGas: 200e9,
  }

[ricmoo]

It does.

But signTransaction does not use populateTransaction since signing a transaction is explicit; you don’t want things not specified being populated, otherwise you won’t be able to do a lot of offline signing.

Only sendTransaction uses populateTransaction.

If you do want nonce and everything else populated you need to call populateTransaction yourself, like wallet.signTransaction(await wallet.populateTransaction(tx)).

Make sense?

[manosamy]

Thanks for the rapid response, I think I used populateTransaction differently, and it didn't work in that flow.

const txn = ERC20ContractInstance.populateTransaction.transfer(receipient, units, {maxFeePerGas, maxPriorityFeePerGas, nonce});
const signed = ERC20ContractInstance.signer.signTransaction(txn);
I have "ethers": "^5.4.7", and got the above error.

After reading this tread, I added type =2 and it worked
const txn = ERC20ContractInstance.populateTransaction.transfer(receipient, units, {type: 2, maxFeePerGas, maxPriorityFeePerGas, nonce});
const signed = ERC20ContractInstance.signer.signTransaction(txn);

Could you please check.
Thanks

[ricmoo]

Just tried and populateTransaction added type 2, but I’m using the latest version. Can you try upgrading?

[manosamy]

Found the problem, it was my misunderstanding.
I assumed erc20ContractInstance.populateTransaction.transfer(params, options) would populate all missing attributes.
It does not. I needed to do this in version 5.5.4:

const txn = await erc20ContractInstance.populateTransaction.transfer(params, options);
const populatedTxn = await erc20ContractInstance.signer.populateTransaction(txn);
const signed = await erc20ContractInstance.signer.signTransaction(populatedTxn);

PS: I also tried faucet.signer.populateTransaction.transfer(params, options), get a typescript error "Property 'transfer' does not exist on type".

[Hamza-shafeeq]

I'm trying to create a flashbot.. but I keep on getting this error when I'm trying to include a victim's transaction (middle transaction) in the bundle

let firstTransaction = {
signer: signingWallet,
transaction: await uniswap.populateTransaction.swapExactETHForTokens(
firstAmountOut,
[
wethAddress,
tokenToCapture,
],
signingWallet.address,
deadline,
{
value: buyAmount,
type: 0,
maxFeePerGas: 69404906714,
maxPriorityFeePerGas: 100000000,
gasLimit: 300000,
// gasPrice: 0x03a994c080,
}
)
}
firstTransaction.transaction = {
...firstTransaction.transaction,
chainId,
}

// 9. Prepare second transaction
const victimsTransactionWithChainId = {
    chainId,
    ...transaction,
}
const signedMiddleTransaction = {
    signedTransaction:  ethers.utils.serializeTransaction(victimsTransactionWithChainId, {
        r: victimsTransactionWithChainId.r,
        s: victimsTransactionWithChainId.s,
        v: victimsTransactionWithChainId.v,
    })
}

// 10. Prepare third transaction for the approval
const erc20 = erc20Factory.attach(tokenToCapture)
let thirdTransaction = {
    signer: signingWallet,
    transaction: await erc20.populateTransaction.approve(
        uniswapAddress,
        firstAmountOut,
        {
            value: '0',
            type: 2,
            maxFeePerGas: 69404906714,
            maxPriorityFeePerGas: 100000000,
            gasLimit: 300000,
        }
    ),
}
thirdTransaction.transaction = {
    ...thirdTransaction.transaction,
    chainId,
}

// 11. Prepare the last transaction to get the final eth
let fourthTransaction = {
    signer: signingWallet,
    transaction: await uniswap.populateTransaction.swapExactTokensForETH(
        firstAmountOut,
        thirdAmountOut,
        [
            tokenToCapture,
            wethAddress,
        ],
        signingWallet.address,
        deadline,
        {
            value: '0',
            type: 2,
            maxFeePerGas: 69404906714,
            maxPriorityFeePerGas: 100000000,
            gasLimit: 300000,
        }
    )
}
fourthTransaction.transaction = {
    ...fourthTransaction.transaction,
    chainId,
}
const transactionsArray = [
    firstTransaction,
    signedMiddleTransaction,
    thirdTransaction,
    fourthTransaction,
]
const signedTransactions = await flashbotsProvider.signBundle(transactionsArray)

Error: invalid object key - maxFeePerGas (argument="transaction:maxFeePerGas", value={"data":"0x7ff36ab5000000000000000000000000000000000000000000000000055c8808a84bf0b40000000000000000000000000000000000000000000000000000000000000080000000000000000000000000c11abeea4084a3b9aaf2b53d336f2a6509578fe700000000000000000000000000000000000000000000000000000000647e4e960000000000000000000000000000000000000000000000000000000000000002000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc200000000000000000000000082bf431453eb58c1be72aa2e40650c42aa219795","to":"0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D","nonce":0,"gasLimit":{"type":"BigNumber","hex":"0x0493e0"},"maxFeePerGas":{"type":"BigNumber","hex":"0x1028dad4da"},"maxPriorityFeePerGas":{"type":"BigNumber","hex":"0x05f5e100"},"type":0,"value":{"type":"BigNumber","hex":"0x2386f26fc10000"},"chainId":1,"gasPrice":{"type":"BigNumber","hex":"0x00"}}, code=INVALID_ARGUMENT, version=properties/5.7.0)
at Logger.makeError (/home/builtinsoft/Documents/hamza/myCryptoBot/node_modules/@ethersproject/logger/lib/index.js:238:21)
at Logger.throwError (/home/builtinsoft/Documents/hamza/myCryptoBot/node_modules/@ethersproject/logger/lib/index.js:247:20)
at Logger.throwArgumentError (/home/builtinsoft/Documents/hamza/myCryptoBot/node_modules/@ethersproject/logger/lib/index.js:250:21)
at /home/builtinsoft/Documents/hamza/myCryptoBot/node_modules/@ethersproject/properties/lib/index.js:93:20
at Array.forEach ()
at checkProperties (/home/builtinsoft/Documents/hamza/myCryptoBot/node_modules/@ethersproject/properties/lib/index.js:91:25)
at _serialize (/home/builtinsoft/Documents/hamza/myCryptoBot/node_modules/@ethersproject/transactions/lib/index.js:173:38)
at serialize (/home/builtinsoft/Documents/hamza/myCryptoBot/node_modules/@ethersproject/transactions/lib/index.js:246:16)
at /home/builtinsoft/Documents/hamza/myCryptoBot/node_modules/@ethersproject/wallet/lib/index.js:163:116
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
reason: 'invalid object key - maxFeePerGas',
code: 'INVALID_ARGUMENT',
argument: 'transaction:maxFeePerGas',