What about eslint?

[teneko]

I was migrating some code from old project to new project and must add a lot of exceptions for overriding JsonRpcBatchProvider:

/* eslint-disable no-param-reassign */
/* eslint-disable prefer-template */
/* eslint-disable @typescript-eslint/no-shadow */
/* eslint-disable object-shorthand */
/* eslint-disable no-underscore-dangle */
/* eslint-disable @typescript-eslint/dot-notation */
import { deepCopy } from "@ethersproject/properties";
import { fetchJson } from "@ethersproject/web";
import { JsonRpcProvider, TransactionResponse } from "@ethersproject/providers";
import { Network } from "@ethersproject/networks";

/** Faster implementation of the native JsonRpcBatchProvider */
export class JsonRpcBatchProvider extends JsonRpcProvider {
...
}

What do you think, is it worth to refactor the code at anytime in the future? maybe with eslint? :)

[PaulRBerg]

You should not run eslint on packages imported from node_modules. Add it to .eslintignore (create the file if necessary).

For an off-the-shelf boilerplate for Solidity development that combines Ethers, Eslint, and more, check out my template:

https://github.com/paulrberg/solidity-template

[ricmoo]

I’d rather not pollute my source code with random tool hints. Everyone has their own choice of tool, and if I add it for one, others will want it for theirs.

I think I hint a few things for nyc, but that’s because it is a tool I use myself.