Should LedgerSigner automatically set nonce, gasPrice and gasLimit?

[maraoz]

Hi, I'm trying to migrate a deployment hardhat+ethers.js script to using LedgerSigner.

I naively tried instantiating a LedgerSigner into a ledger variable and just added .connect(ledger) before any line that previously sent a transaction.

However, I noticed the transactions show up with 0 "Max Fees" on my device, and getting a ProviderError: transaction underpriced error after signing.

Inspecting the code for LedgerSigner a bit, it seems to leave most options undefined unless explicitly set. However, I'm not sure how ethers.js handles the automagic gas estimation, gas price calculation, etc in the "usual" case (which I'm guessing uses JsonRpcSigner?), so maybe I'm wrong, and this should be working.

My question is: do I have to provide all the transaction options manually for LedgerSigner, or I'm doing something else wrong? Is there anything else I should be changing when using LedgerSigner?

Thanks in advance!

[ricmoo]

Are you using .signTransaction or .sendTransacion? No Signer should populate any values for .signTransaction as that method is lower-level and requires finer tuned values (as it may be used to meta-transactions and such), while .sendTransaction will use the .populateTransaction method first to ensure all values necessary for the transaction are correct and necessarily populated.

Note that the JsonRpcSigner does not use /populateTransaction since the values required are maintained by the signing authority (e.g. nonce).

There is also currently an issue with the LedgerSigner I'm working on, and am moving it to an ancillary package so that it can more reliably be managed as the upstream dependencies are somewhat picky. :)

[maraoz]

I'm using contractFactory.deploy(), and openzeppelin's upgrades hardhat plugin, actually. I've pushed my current code to a branch to make it easier for you to help, sorry for not doing that earlier.

Here's the commit that attempts to switch from using the mnemonic wallet to Ledger:
https://github.com/maraoz/rewilder/commit/064204c17db733c64dabf7d2d8856de7a07b4f23

When you see ethers.getContractFactory("..."), that's a hardhat plugin/util that returns an ethers.js ContractFactory for the contract of that name, using hardhat environment.

I'm still trying to see where I'm doing something wrong, will keep this discussion updated if I discover anything new.
I also have a more complex case (upgradeable contract) in that script, but I'm leaving sorting that out for later :)

[maraoz]

I think I might be messing up by asking hardhat to use a mnemonic in the config (https://github.com/maraoz/rewilder/blob/dapp-hardware/hardhat.config.js#L56) which probably creates a Wallet somewhere and then attempting to sign with an "external" signer.

As far as I understand so far, hardhat uses a provider called EthersProviderWrapper which might be the source of my problems. Seems like I should be asking around the hardhat community at this point. Sorry for bothering here!

[maraoz]

Ah no, after adding lots of console.logs everywhere, I think it's another instance of: https://github.com/ethers-io/ethers.js/issues/2078

I think it's an incompatibility problem with LedgerSigner and type==2 transactions.
My guess is (in case it helps with fixing this bug): when populateTransaction sets maxFeePerGas and maxPriorityFeePerGas but deletes tx.gasPrice here, it makes this line always return undefined

No matter how or when I set gasPrice, it somehow gets deleted by populateTransaction and makes gasPrice be undefined when signTransaction is called.