Transaction replacement detection seems too strict

[mverzilli]

Hi everyone! I've been struggling to have the TRANSACTION_REPLACEMENT error thrown as documented. After a lot of debugging, I noted that there's a data format mismatch between the TXs pulled from scanned blocks and the replaceable model that etherjs builds to compare and detect replacements. See screenshot:

Notice that:

1. tx.from is all lower case whereas replaceable.from is a checksummed address, but both values represent the same address.
2. tx.nonce is 0x334 (ie: 820 in hex), while replaceable.nonce is the number 820.

Given the above, replacement transactions are never detected, at least in my env. Has anyone stumbled upon this issue? Should I open PR making this comparison a little more resilient to data formats?

[ricmoo]

Looking into this.

[ricmoo]

Quick question; what version are you currently using?

Also, see #2133 to track this issue.

Thanks! :)

[mverzilli]

Thanks for the super quick response! We're on v5.4.4

[ricmoo]

I was trying to reproduce this and couldn't; I believe it was fixed by #1858. Can you update to the latest version and see if you still have this issue?

[mverzilli]

Thank you for looking into this @ricmoo! I'll try to get to it before the end of the week (I'm a bit distracted by the LisCon at the moment :D)