providers.waitForTransaction return type does not match documentation

[rhinodavid]

The documentation for the providers waitForTransaction method [link] notes: If confirms is 0, this method is non-blocking and if the transaction has not been mined returns null. However, the return type for the function is Promise<TransactionReceipt> [link].

Should the type be updated to Promise<TransactionReceipt | null> or is it possible the documentation is incorrect?

[ricmoo]

In v5, the strictNullCheck is not enabled. It is in v6, but for v5 null is always implicitly permitted.