Should the BigNumberish type support BigInt?

[mds1]

(I think this feels more like a discussion/question than an actual issue, so I've placed it here 😬 )

Right now the type definition is export type BigNumberish = BigNumber | Bytes | string | number;, but it seems BigInt's are supported anywhere BigNumber is supported, so perhaps this should be export type BigNumberish = BigNumber | Bytes | string | number | bigint;

Currently trying to pass a BigInt when BigNumberish is expected gives Argument of type 'bigint' is not assignable to parameter of type 'BigNumberish'. ts(2345)

[ricmoo]

Yes. It definitely should. And now that I have scripts to perform minor version bumps, I will add this in the next minor version, since it does impact signatures.

Good call! :)

[mds1]

I see some recent minor version bumps, but don't see this yet, so here is a friendly reminder! 😁

[ricmoo]

I think you are looking at patch version bumps, not minor. There has only ever been 1 minor bump. :)

This has already been added to 5.2, which will be released soon. :)

[mds1]

Ha, oops you are right, sorry! 🤦