Throw an error on conflict when inserting a verified_contract #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the storageService reference from SourcifyDatabaseService because it was not used Corrects the StorageLayout type which didn't match the VerificationExport before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2167
This will make the verification job fail, if the server cannot store a new
verified_contractdue to a conflict with the constraints. The error code of the job will be aninternal_errorbecause, in future, this case should not be encountered regularly and generally points to a bug on our side. We only have it in #2092 because the contracts were verified with a buggy version of Sourcify before.Also: