You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/checklist_templates/eip_testing_checklist_template.md
+35-4Lines changed: 35 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -80,7 +80,7 @@ The EIP introduces one or more new opcodes to the EVM.
80
80
### Framework Changes
81
81
82
82
-[ ] Add opcode to `src/ethereum_test_vm/opcode.py`
83
-
-[ ] Add opcode to relevant methods in the fork it is introduced in `src/ethereum_test_forks/forks/forks.py`
83
+
-[ ] Add opcode to relevant methods in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py`
84
84
85
85
## New Precompile
86
86
@@ -127,7 +127,7 @@ The EIP introduces one or more new opcodes to the EVM.
127
127
128
128
### Framework Changes
129
129
130
-
-[ ] Add precompile address to relevant methods in the fork it is introduced in `src/ethereum_test_forks/forks/forks.py`
130
+
-[ ] Add precompile address to relevant methods in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py`
131
131
132
132
## New System Contract
133
133
@@ -174,28 +174,59 @@ The EIP introduces one or more new opcodes to the EVM.
174
174
175
175
### Framework Changes
176
176
177
-
-[ ] Add system contract address to relevant methods in the fork it is introduced in `src/ethereum_test_forks/forks/forks.py`
177
+
-[ ] Add system contract address to relevant methods in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py`
178
178
179
179
## New Block Header Field
180
180
181
181
### Test Vectors
182
182
183
+
**TBD**
184
+
183
185
### Framework Changes
184
186
187
+
**TBD**
188
+
189
+
185
190
## New Block Body Field
186
191
187
192
### Test Vectors
188
193
194
+
**TBD**
195
+
189
196
### Framework Changes
190
197
198
+
**TBD**
199
+
200
+
191
201
## New Transaction Type
192
202
193
203
### Test Vectors
194
204
205
+
-[ ] Intrinsic Gas Costs
206
+
-[ ] Transaction validity
207
+
- [] Verify the transaction (and the block it is included in) is valid by providing the exact intrinsic gas as `gas_limit` value to the transaction.
208
+
- [] Verify the transaction (and the block it is included in) is invalid by providing the exact intrinsic gas minus one as `gas_limit` value to the transaction.
209
+
-[ ] Encoding Tests
210
+
-[ ] Verify correct transaction rejection due to incorrect field sizes
211
+
-[ ] RPC Tests*
212
+
-[ ] Verify `eth_estimateGas` behavior for different valid combinations of the new transaction type.
213
+
214
+
215
+
* Tests must be added to [`execution-apis`](https://github.com/ethereum/execution-apis) repository.
216
+
195
217
### Framework Changes
196
218
197
-
## Intrinsic Gas Cost Changes
219
+
-[ ] Modify `transaction_intrinsic_cost_calculator` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py`, adding the appropriate new fields that the transaction introduced and the logic to the intrinsic gas cost calculation, if any.
220
+
221
+
## Gas Cost Changes
198
222
199
223
### Test Vectors
200
224
225
+
**TBD**
226
+
201
227
### Framework Changes
228
+
229
+
-[ ] Modify `transaction_intrinsic_cost_calculator` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py` if the EIP affects intrinsic gas cost calculation.
230
+
-[ ] Modify `transaction_data_floor_cost_calculator` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py` if the EIP affects calldata floor cost.
231
+
-[ ] Modify `memory_expansion_gas_calculator` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py` if the EIP affects memory expansion gas cost calculation.
232
+
-[ ] Modify `gas_costs` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py` if the EIP affects specific opcode gas costs.
0 commit comments