Skip to content

Commit c93a405

Browse files
committed
changes: Add (incomplete) transaction tests
1 parent e8d96bc commit c93a405

File tree

1 file changed

+35
-4
lines changed

1 file changed

+35
-4
lines changed

docs/checklist_templates/eip_testing_checklist_template.md

Lines changed: 35 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ The EIP introduces one or more new opcodes to the EVM.
8080
### Framework Changes
8181

8282
- [ ] Add opcode to `src/ethereum_test_vm/opcode.py`
83-
- [ ] Add opcode to relevant methods in the fork it is introduced in `src/ethereum_test_forks/forks/forks.py`
83+
- [ ] Add opcode to relevant methods in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py`
8484

8585
## New Precompile
8686

@@ -127,7 +127,7 @@ The EIP introduces one or more new opcodes to the EVM.
127127

128128
### Framework Changes
129129

130-
- [ ] Add precompile address to relevant methods in the fork it is introduced in `src/ethereum_test_forks/forks/forks.py`
130+
- [ ] Add precompile address to relevant methods in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py`
131131

132132
## New System Contract
133133

@@ -174,28 +174,59 @@ The EIP introduces one or more new opcodes to the EVM.
174174

175175
### Framework Changes
176176

177-
- [ ] Add system contract address to relevant methods in the fork it is introduced in `src/ethereum_test_forks/forks/forks.py`
177+
- [ ] Add system contract address to relevant methods in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py`
178178

179179
## New Block Header Field
180180

181181
### Test Vectors
182182

183+
**TBD**
184+
183185
### Framework Changes
184186

187+
**TBD**
188+
189+
185190
## New Block Body Field
186191

187192
### Test Vectors
188193

194+
**TBD**
195+
189196
### Framework Changes
190197

198+
**TBD**
199+
200+
191201
## New Transaction Type
192202

193203
### Test Vectors
194204

205+
- [ ] Intrinsic Gas Costs
206+
- [ ] Transaction validity
207+
- [ ] Verify the transaction (and the block it is included in) is valid by providing the exact intrinsic gas as `gas_limit` value to the transaction.
208+
- [ ] Verify the transaction (and the block it is included in) is invalid by providing the exact intrinsic gas minus one as `gas_limit` value to the transaction.
209+
- [ ] Encoding Tests
210+
- [ ] Verify correct transaction rejection due to incorrect field sizes
211+
- [ ] RPC Tests*
212+
- [ ] Verify `eth_estimateGas` behavior for different valid combinations of the new transaction type.
213+
214+
215+
* Tests must be added to [`execution-apis`](https://github.com/ethereum/execution-apis) repository.
216+
195217
### Framework Changes
196218

197-
## Intrinsic Gas Cost Changes
219+
- [ ] Modify `transaction_intrinsic_cost_calculator` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py`, adding the appropriate new fields that the transaction introduced and the logic to the intrinsic gas cost calculation, if any.
220+
221+
## Gas Cost Changes
198222

199223
### Test Vectors
200224

225+
**TBD**
226+
201227
### Framework Changes
228+
229+
- [ ] Modify `transaction_intrinsic_cost_calculator` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py` if the EIP affects intrinsic gas cost calculation.
230+
- [ ] Modify `transaction_data_floor_cost_calculator` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py` if the EIP affects calldata floor cost.
231+
- [ ] Modify `memory_expansion_gas_calculator` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py` if the EIP affects memory expansion gas cost calculation.
232+
- [ ] Modify `gas_costs` in the fork where the EIP is introduced in `src/ethereum_test_forks/forks/forks.py` if the EIP affects specific opcode gas costs.

0 commit comments

Comments
 (0)