Skip to content

Commit 9a3c5fa

Browse files
committed
More review comments
1 parent f2189d9 commit 9a3c5fa

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

docs/checklist_templates/eip_testing_checklist_template.md

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,8 @@ The EIP introduces one or more new opcodes to the EVM.
226226
- [ ] Verify the transaction (and the block it is included in) is invalid if the transaction contains a value of 1 and the account does not contain enough funds to cover the intrinsic transaction cost plus 1.
227227
- [ ] Data:
228228
- [ ] Verify the transaction (and the block it is included in) is invalid if the transaction contains enough data so the data floor cost is higher than the intrinsic gas cost and the gas_limit is equal to the intrinsic gas gost.
229+
- [ ] Sender balance:
230+
- [ ] Verify the transaction (and the block it is included in) is invalid when the sender account does not have enough balance to cover the gas limit multiplied by the max fee per gas.
229231
- [ ] Signature:
230232
- [ ] Verify the transaction is correctly rejected if it contains an invalid signature:
231233
- [ ] V, R, S represent a value that is inside of the field but outside of the curve.
@@ -254,8 +256,17 @@ The EIP introduces one or more new opcodes to the EVM.
254256
- [ ] `2**256-1`
255257
- [ ] `2**256`
256258
- [ ] `SECP256K1N - S` of a valid signature
257-
- [ ] Encoding Tests (RLP, SSZ)
258-
- [ ] Verify correct transaction rejection due to incorrect field sizes
259+
- Transaction-Scoped Attributes/Variables
260+
- Verify attributes that can be read in the EVM from transaction fields.
261+
- Verify values or variables that are persistent through the execution of the transaction (transient storage, warm/cold accounts).
262+
- [ ] Encoding (RLP, SSZ)
263+
- [ ] Verify correct transaction rejection due to incorrect field sizes:
264+
- [ ] Add leading zero byte
265+
- [ ] Remove single byte from fixed-byte-length fields
266+
- [ ] If the transaction contains a new field that is a list, verify:
267+
- [ ] Zero-element list
268+
- [ ] Max count list
269+
- [ ] Max count plus one list
259270
- [ ] Verify correct transaction rejection if the fields particular to the new transaction types are missing
260271
- [ ] Verify correct transaction rejection if the transaction type contains extra fields
261272
- [ ] If the transaction contains fields with new serializable types, perform all previous tests on the new type/field
@@ -266,7 +277,7 @@ The EIP introduces one or more new opcodes to the EVM.
266277
- [ ] Contract creation
267278
- [ ] Verify that the transaction can create new contracts if the transaction type supports it.
268279
- [ ] Sender account modifications
269-
- [ ] Verify that the sender account of the new transaction type transaction has its nonce incremented by one after the transaction is included in a block
280+
- [ ] Verify that the sender account of the new transaction type transaction has its nonce incremented at least by one after the transaction is included in a block (or more if the transaction type introduces a new mechanic that bumps the nonce by more than one).
270281
- [ ] Verify that the sender account of the new transaction type transaction has its balance reduced by the correct amount (gas consumed and value) after the transaction is included in a block
271282
- [ ] Fork transition
272283
- [ ] Verify that a block prior to fork activation where the new transaction type is introduced and containing the new transaction type is invalid.

0 commit comments

Comments
 (0)