feat(fill,zkevm): suppress high tx gas limit warnings for zkevm tests (#1598)

* refactor(spec): rename `is_slow_test()` to `is_tx_gas_heavy_test()`

  This updates the terminology to better reflect that we're identifying tests with
  transactions that consume a lot of gas rather than focusing on execution time.

* feat(spec): prevent zkevm tests from raising tx gas limit warnings

* docs: update changelog

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>

Author: danceratopz

docs/CHANGELOG.md

@@ -13,6 +13,7 @@ Test fixtures for use by clients are available for each release on the [Github r
 #### `fill`
 
 - 🔀 Refactor: Encapsulate `fill`'s fixture output options (`--output`, `--flat-output`, `--single-fixture-per-file`) into a `FixtureOutput` class ([#1471](https://github.com/ethereum/execution-spec-tests/pull/1471)).
+- ✨ Don't warn about a "high Transaction gas_limit" for `zkevm` tests ([#1598](https://github.com/ethereum/execution-spec-tests/pull/1598)).
 
 #### `consume`
 

src/ethereum_test_specs/base.py

@@ -139,10 +139,13 @@ def get_next_transition_tool_output_path(self) -> str:
             str(current_value),
         )
 
-    def is_slow_test(self) -> bool:
-        """Check if the test is slow."""
+    def is_tx_gas_heavy_test(self) -> bool:
+        """Check if the test is gas-heavy for transaction execution."""
         if self._request is not None and hasattr(self._request, "node"):
-            return self._request.node.get_closest_marker("slow") is not None
+            node = self._request.node
+            has_slow_marker = node.get_closest_marker("slow") is not None
+            has_zkevm_marker = node.get_closest_marker("zkevm") is not None
+            return has_slow_marker or has_zkevm_marker
         return False
 
     def is_exception_test(self) -> bool | None:

src/ethereum_test_specs/blockchain.py

@@ -402,7 +402,6 @@ def generate_block_data(
         previous_env: Environment,
         previous_alloc: Alloc,
         eips: Optional[List[int]] = None,
-        slow: bool = False,
     ) -> Tuple[FixtureHeader, List[Transaction], List[Bytes] | None, Alloc, Environment]:
         """Generate common block data for both make_fixture and make_hive_fixture."""
         if block.rlp and block.exception is not None:
@@ -417,7 +416,7 @@ def generate_block_data(
 
         txs: List[Transaction] = []
         for tx in block.txs:
-            if not self.is_slow_test() and tx.gas_limit >= Environment().gas_limit:
+            if not self.is_tx_gas_heavy_test() and tx.gas_limit >= Environment().gas_limit:
                 warnings.warn(
                     f"{self.node_id()} uses a high Transaction gas_limit: {tx.gas_limit}",
                     stacklevel=2,
@@ -446,7 +445,7 @@ def generate_block_data(
             blob_schedule=fork.blob_schedule(),
             eips=eips,
             debug_output_path=self.get_next_transition_tool_output_path(),
-            slow_request=slow,
+            slow_request=self.is_tx_gas_heavy_test(),
         )
 
         try:
@@ -598,7 +597,6 @@ def make_fixture(
                     previous_env=env,
                     previous_alloc=alloc,
                     eips=eips,
-                    slow=self.is_slow_test(),
                 )
                 fixture_block = FixtureBlockBase(
                     header=header,
@@ -687,7 +685,6 @@ def make_hive_fixture(
                 previous_env=env,
                 previous_alloc=alloc,
                 eips=eips,
-                slow=self.is_slow_test(),
             )
             if block.rlp is None:
                 fixture_payloads.append(

src/ethereum_test_specs/state.py

@@ -170,7 +170,7 @@ def make_state_test_fixture(
 
         env = self.env.set_fork_requirements(fork)
         tx = self.tx.with_signature_and_sender(keep_secret_key=True)
-        if not self.is_slow_test() and tx.gas_limit >= Environment().gas_limit:
+        if not self.is_tx_gas_heavy_test() and tx.gas_limit >= Environment().gas_limit:
             warnings.warn(
                 f"{self.node_id()} uses a high Transaction gas_limit: {tx.gas_limit}",
                 stacklevel=2,
@@ -193,7 +193,7 @@ def make_state_test_fixture(
             eips=eips,
             debug_output_path=self.get_next_transition_tool_output_path(),
             state_test=True,
-            slow_request=self.is_slow_test(),
+            slow_request=self.is_tx_gas_heavy_test(),
         )
 
         try: