Skip to content

Commit 2468227

Browse files
committed
Add more encoding tests
1 parent b2e5b58 commit 2468227

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

docs/checklist_templates/eip_testing_checklist_template.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,11 @@ The EIP introduces one or more new opcodes to the EVM.
197197
- [ ] Transaction validity: For each new field that affects the intrinsic gas cost of the transaction:
198198
- [ ] Verify the transaction (and the block it is included in) is valid by providing the exact intrinsic gas as `gas_limit` value to the transaction with all multiple combinations of values to the field.
199199
- [ ] Verify the transaction (and the block it is included in) is invalid by providing the exact intrinsic gas minus one as `gas_limit` value to the transaction with all multiple combinations of values to the field.
200-
- [ ] Encoding Tests
200+
- [ ] Encoding Tests (RLP, SSZ)
201201
- [ ] Verify correct transaction rejection due to incorrect field sizes
202+
- [ ] Verify correct transaction rejection if the fields particular to the new transaction types are missing
203+
- [ ] Verify correct transaction rejection if the transaction type contains extra fields
204+
- [ ] If the transaction contains fields with new serializable types, perform all previous tests on the new type/field
202205
- [ ] RPC Tests
203206
- [ ] * Verify `eth_estimateGas` behavior for different valid combinations of the new transaction type
204207
- [ ] Verify `eth_sendRawTransaction` using `execute`

0 commit comments

Comments
 (0)