Merge pull request #1144 from ethereum/close-search

samajammin · web-flow · commit f8662f577091 · 2020-06-25T15:11:27.000-07:00
Strip URL on search [Fixes #1143]
diff --git a/src/components/Search/index.js b/src/components/Search/index.js
@@ -110,9 +110,11 @@ const StyledHighlight = styled(Highlight)`
 `
 
 const PageHit = (clickHandler) => ({ hit }) => {
+  // Make url relative, so `handleSelect` is triggered
+  const url = hit.url.replace("https://ethereum.org", "")
   return (
     <div>
-      <GatsbyLink to={hit.url} onClick={clickHandler}>
+      <GatsbyLink to={url} onClick={clickHandler}>
         <PageHeader>
           <Highlight attribute="hierarchy.lvl1" hit={hit} tagName="mark" />
         </PageHeader>
@@ -138,6 +140,7 @@ const PageHit = (clickHandler) => ({ hit }) => {
   )
 }
 
+// TODO update to `dev-ethereum-org` once tested
 const indices = [
   { name: `dev-ethereum-org`, title: `Pages`, hitComp: `PageHit` },
 ]

Original file line number	Diff line number	Diff line change
@@ -110,9 +110,11 @@ const StyledHighlight = styled(Highlight)`
`110`	`110`	`
`111`	`111`
`112`	`112`	`const PageHit = (clickHandler) => ({ hit }) => {`
	`113`	+ // Make url relative, so `handleSelect` is triggered
	`114`	`+ const url = hit.url.replace("https://ethereum.org", "")`
`113`	`115`	`return (`
`114`	`116`	`<div>`
`115`		`- <GatsbyLink to={hit.url} onClick={clickHandler}>`
	`117`	`+ <GatsbyLink to={url} onClick={clickHandler}>`
`116`	`118`	`<PageHeader>`
`117`	`119`	`<Highlight attribute="hierarchy.lvl1" hit={hit} tagName="mark" />`
`118`	`120`	`</PageHeader>`
`@@ -138,6 +140,7 @@ const PageHit = (clickHandler) => ({ hit }) => {`
`138`	`140`	`)`
`139`	`141`	`}`
`140`	`142`
	`143`	+// TODO update to `dev-ethereum-org` once tested
`141`	`144`	`const indices = [`
`142`	`145`	{ name: `dev-ethereum-org`, title: `Pages`, hitComp: `PageHit` },
`143`	`146`	`]`