Skip to content

Commit ede4307

Browse files
authored
Merge branch 'dev' into jc-block-production
2 parents f39cd95 + b506020 commit ede4307

File tree

653 files changed

+37312
-26008
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

653 files changed

+37312
-26008
lines changed

.all-contributorsrc

Lines changed: 552 additions & 3 deletions
Large diffs are not rendered by default.

README.md

Lines changed: 80 additions & 4 deletions
Large diffs are not rendered by default.

docs/best-practices.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Markdown will be translated as whole pages of content, so no specific action is
5252

5353
- _tl;dr Each individual JSON entry should be a complete phrase by itself_
5454

55-
- This is done using the `Translation` component. However there is an alternative method for regular JS: `gatsby-theme-i18n` with `/src/utils/translations.ts`
55+
- This is done using the `Translation` component. However there is an alternative method for regular JS: using the `t` function from `gatsby-plugin-react-i18next`
5656

5757
- **Method one: `<Translation />` component (preferred if only needed in JSX)**
5858

@@ -63,19 +63,18 @@ Markdown will be translated as whole pages of content, so no specific action is
6363
;<Translation id="language-json-key" />
6464
```
6565

66-
- **Method two: `translateMessageId()`**
66+
- **Method two: `t()`**
6767

6868
```tsx
69-
import { useIntl } from "react-intl"
70-
import { translateMessageId } from "src/utils/translations"
69+
import { useTranslation } from "gatsby-plugin-react-i18next"
7170
7271
// Utilize anywhere in JS using
73-
const intl = useIntl()
74-
translateMessageId("language-json-key", intl)
72+
const { t } = useTranslation()
73+
t("language-json-key")
7574
```
7675

7776
```tsx
78-
const siteTitle = translateMessageId("site-title", intl)
77+
const siteTitle = t("site-title")
7978
```
8079

8180
## React Hooks

docs/deploy-and-review-process.md

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
# Deploy and review process
2+
3+
This documentation outlines our current processes for how we deploy the latest changes to ethereum.org, and how we prioritize items in our review process.
4+
5+
## Deploy process
6+
7+
Anything merged into the `dev` branch of [ethereum.org](http://ethereum.org) will go live on ethereum.org at the next release. Currently, we deploy the latest changes to [ethereum.org](http://ethereum.org) twice per week (Monday and Thursday). When deploying, we merge the `dev` branch into the `master` branch. The `master` branch is the latest live version of [ethereum.org](https://ethereum.org).
8+
9+
Occasionally, we’ll also do a patch deploy to fix an urgent or widespread issue.
10+
11+
## Review process
12+
13+
### General review process
14+
15+
We use a first-in, first-out system for reviewing pull requests. The longer a pull request has been open, the higher priority it is for our team to review. In some cases—for example, fixing a high-priority issue or merging low-hanging fruit for a deploy—we will stray from this process and use our best judgement to get higher-impact changes deployed more quickly.
16+
17+
We aim to have every new PR merged or closed within 30 days of opening. As outlined in the following sections, different types of pull requests do have different levels of priority, and this may influence how promptly a pull request is acted on.
18+
19+
### Translations
20+
21+
Translation pull requests are considered high priority. These are when the translated and reviewed files from our translation management platform are submitted as a pull request. They are important to our core value of bringing Ethereum education to as many languages as possible. They also are the accumulation of months of work by translators and reviewers, and any delay to this already long process is undesirable.
22+
23+
**Timeline:** PRs should be merged within 1-4 days of opening (by the next release).
24+
25+
### Feature and bug fixes
26+
27+
Any new feature correlated to an approved issue or bug fix is high-priority. Similar to translators, code contributors dedicate a large amount of their time to improving [ethereum.org](http://ethereum.org) as a resource and addressing their efforts quickly is desirable. All bug fixes should be handled swiftly, but new features that were not discussed, requested or approved do not fall under this timeline.
28+
29+
**Timeline:** Features or bug fixes should be reviewed within 1-12 days. In the case of bugs, more severe bugs will be reviewed more promptly.
30+
31+
### Content
32+
33+
Content PRs are considered medium-priority. Depending on their content, they can be very high-impact but also a high effort to go through the various stages of content review to ensure the content meets the standards we aim for. Content PRs can be broken into two categories: major content (e.g. a new page) and minor content changes (e.g. a new section to an existing page). Typo or grammar fixes are considered separately.
34+
35+
**Timeline:** Major content should be merged within 15-30 days of opening. Minor content changes within 5-15 days of opening.
36+
37+
### Typographical and grammatical errors
38+
39+
Typographical and grammatical errors are medium-priority as small errors of this kind can have second-order ramifications for the linguists of the ~50 languages we currently translate to. Though technically a subgroup of ‘content PRs’, typos and grammar errors take significantly less time to review and, as a result, are treated differently.
40+
41+
**Timeline:** Typo or grammar pull requests should be merged within 1-8 days of opening.
42+
43+
### Adding products
44+
45+
Adding new products is currently a low-to-medium priority (depending on the type of product). These pull requests often take a long time to review as we must extensively research products to ensure we not sending our users to any dubious or unsafe products.
46+
47+
**Timeline:** PRs should be closed or merged within 30 days of opening.
48+
49+
### Adding tutorials
50+
51+
Adding new tutorials to [ethereum.org](http://ethereum.org) is currently low-priority. We are currently in the middle of an epic to revamp our tutorials. As part of this, we’ll be reviewing our existing tutorials, purging outdated or low-quality tutorials, and refining our listing criteria for future tutorials to meet our increased standards. Please always create an issue to discuss the usefulness of your proposed tutorial before opening a PR.
52+
53+
**Timeline:** PRs should be closed or merged within 30 days of opening.

docs/stack.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
- [Gatsby Docs](https://www.gatsbyjs.org/docs/)
1010
- [React](https://reactjs.org/) - A JavaScript library for building component-based user interfaces
1111
- [Typescript](https://www.typescriptlang.org/) - TypeScript is a strongly typed programming language that builds on JavaScript
12+
- [Chakra UI](https://chakra-ui.com/) - A UI library (Migration in progress)
1213
- [GraphQL](https://graphql.org/) - A query language for APIs
1314
- [Algolia](https://www.algolia.com/) - Site indexing, rapid intra-site search results, and search analytics. [Learn more on how we implement Algolia for site search](./docs/ALGOLIA_DOCSEARCH.md).
1415
- Primary implementation: `/src/components/Search/index.ts`

i18n/config.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,14 @@
343343
"langDir": "ltr",
344344
"dateFormat": "MM/DD/YYYY"
345345
},
346+
{
347+
"code": "ta",
348+
"hrefLang": "ta",
349+
"name": "Tamil",
350+
"localName": "தமிழ்",
351+
"langDir": "ltr",
352+
"dateFormat": "MM/DD/YYYY"
353+
},
346354
{
347355
"code": "th",
348356
"hrefLang": "th",

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ethereum-org-website",
3-
"version": "6.7.4",
3+
"version": "6.13.0",
44
"description": "Website of ethereum.org",
55
"main": "index.js",
66
"repository": "git@github.com:ethereum/ethereum-org-website.git",

src/@chakra-ui/gatsby-plugin/components/Button.ts

Lines changed: 37 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
import type { ComponentStyleConfig } from "@chakra-ui/theme"
22

3+
const disabledStylesSolid = {
4+
bg: "disabled",
5+
opacity: 1,
6+
}
7+
8+
const disabledStylesOutline = {
9+
color: "disabled",
10+
borderColor: "disabled",
11+
opacity: 1,
12+
}
13+
314
const commonOutline = {
415
border: "1px",
516
color: "text",
@@ -9,6 +20,9 @@ const commonOutline = {
920
color: "primary",
1021
bg: "background",
1122
borderColor: "primary",
23+
_disabled: {
24+
...disabledStylesOutline,
25+
},
1226
},
1327
_active: {
1428
color: "primary",
@@ -18,11 +32,12 @@ const commonOutline = {
1832
_focus: {
1933
color: "primary",
2034
borderColor: "background",
35+
_disabled: {
36+
...disabledStylesOutline,
37+
},
2138
},
2239
_disabled: {
23-
color: "disabled",
24-
borderColor: "disabled",
25-
opacity: 1,
40+
...disabledStylesOutline,
2641
},
2742
}
2843

@@ -33,6 +48,9 @@ export const Button: ComponentStyleConfig = {
3348
_hover: {
3449
textDecoration: "none",
3550
boxShadow: "primary",
51+
_disabled: {
52+
boxShadow: "none",
53+
},
3654
},
3755
_focus: {
3856
boxShadow: "outline",
@@ -53,13 +71,15 @@ export const Button: ComponentStyleConfig = {
5371
_hover: {
5472
bg: "primary",
5573
opacity: 0.8,
74+
_disabled: {
75+
...disabledStylesSolid,
76+
},
5677
},
5778
_active: {
5879
bg: "primaryHover",
5980
},
6081
_disabled: {
61-
bg: "disabled",
62-
opacity: 1,
82+
...disabledStylesSolid,
6383
},
6484
},
6585
outline: {
@@ -70,5 +90,17 @@ export const Button: ComponentStyleConfig = {
7090
color: "primary",
7191
borderColor: "primary",
7292
},
93+
icon: {
94+
appearance: "none",
95+
background: "inherit",
96+
padding: "initial",
97+
border: 0,
98+
color: "inherit",
99+
boxShadow: "none",
100+
_hover: {
101+
color: "primary",
102+
boxShadow: "none",
103+
},
104+
},
73105
},
74106
}
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
import type { ComponentStyleConfig } from "@chakra-ui/theme"
2+
3+
export const Tabs: ComponentStyleConfig = {
4+
variants: {
5+
primary: {
6+
tab: {
7+
borderTopRadius: "0.3rem",
8+
borderBottom: "1px solid",
9+
borderBottomColor: "primary",
10+
px: 4,
11+
py: "0.3rem",
12+
_selected: {
13+
color: "background",
14+
bg: "primary",
15+
},
16+
},
17+
tabpanels: {
18+
mt: 4,
19+
},
20+
tabpanel: {
21+
p: 6,
22+
bg: "ednBackground",
23+
border: "1px solid",
24+
borderColor: "lightBorder",
25+
borderRadius: "lg",
26+
},
27+
},
28+
},
29+
defaultProps: {
30+
variant: "primary",
31+
},
32+
}

src/@chakra-ui/gatsby-plugin/components/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@ import { Link } from "./Link"
33
import { Tag } from "./Tag"
44
import { Modal } from "./Modal"
55
import { Checkbox } from "./Checkbox"
6+
import { Tabs } from "./Tabs"
67

78
export default {
89
Button,
910
Link,
1011
Tag,
1112
Modal,
1213
Checkbox,
14+
Tabs,
1315
}

0 commit comments

Comments
 (0)