Skip to content

Commit c28624c

Browse files
authored
Merge pull request #1355 from ethereum/meta-cleanup
Meta cleanup
2 parents c538935 + 659a62b commit c28624c

File tree

6 files changed

+38
-16
lines changed

6 files changed

+38
-16
lines changed

.github/ISSUE_TEMPLATE/new_exchange.md renamed to .github/ISSUE_TEMPLATE/suggest_exchange.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,24 @@
11
---
2-
name: Add an exchange
3-
about: Suggest a new exchange for us to list
2+
name: Suggest an exchange
3+
about: Suggest a new exchange to list on ethereum.org
44
title: ""
5-
labels: "Type: Feature"
5+
labels: "Type: Feature", "Type: Content"
66
assignees: ""
77
---
88

9-
Please fill out this short form if you'd like an exchange added to ethereum.org. If it's a decentralized exchange (DEX) you'd like to list, please take a look at our [policy for listing dapps](https://ethereum.org/en/contributing/adding-products/).
9+
Before suggesting an exchange, make sure you've read [our exchange listing policy](https://ethereum.org/en/contributing/adding-exchanges/). If it's a decentralized exchange (DEX) you'd like to list, please take a look at our [policy for listing dapps](https://ethereum.org/en/contributing/adding-products/).
1010

11-
**What geographical restrictions apply to this exchange?**
11+
Please fill out this short form if you'd like an exchange added to ethereum.org:
12+
13+
**What geographical restrictions apply to this exchange?**
1214

1315
<!-- If you don't know, please get in touch with the exchange. They'll likely have a list of restricted countries and jurisdictions. -->
1416

1517
**Which currencies are accepted by this exchange?**
1618

1719
<!-- If you don't know, please get in touch with the exchange. They'll likely have a list of accepted currencies -->
1820

19-
**Do you have any proof that they're a legitimate company**
21+
**Do you have any proof that they're a legitimate company?**
2022

2123
<!-- This is a safeguard against listing any malicious sites. You could provide a link to an "About" page from the exchange that provides more information about their legal entity, or a link to an official company registration -->
2224

.github/ISSUE_TEMPLATE/add_wallet.md renamed to .github/ISSUE_TEMPLATE/suggest_wallet.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
---
22
name: Suggest a wallet
3-
about: Suggest a new wallet to list
3+
about: Suggest a new wallet to list on ethereum.org
44
title: ""
5-
labels: "Type: Feature"
5+
labels: "Type: Feature", "Type: Content"
66
assignees: ""
77
---
88

@@ -16,7 +16,7 @@ If it does complete the following information which we need to accurately list t
1616

1717
<!-- Does the wallet subsidise transaction fees for all or some wallet activity? -->
1818

19-
**Does the wallet allow users to explore dapps**
19+
**Does the wallet allow users to explore dapps?**
2020

2121
<!-- Is the wallet integrated with WalletConnect? Does it have a dapp browser? Or can users connect to a dapp using the wallet? -->
2222

@@ -28,7 +28,7 @@ If it does complete the following information which we need to accurately list t
2828

2929
<!-- Can a user cash out their crypto assets directly to a card or bank account? -->
3030

31-
**Does the wallet have limits protection?**
31+
**Does the wallet offer limits protection?**
3232

3333
<!-- Can a user set a limit for transfers to protect their assets? -->
3434

@@ -44,7 +44,11 @@ If it does complete the following information which we need to accurately list t
4444

4545
<!-- Can a user opt to require multiple signatures to authorise transactions? -->
4646

47-
**Wallet blurb**
47+
**Wallet title**
48+
49+
<!-- Please provide the official name of the wallet -->
50+
51+
**Wallet description**
4852

4953
<!-- Please provide a short 1-2 sentence description of the wallet -->
5054

src/components/WalletCompare.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import { Content, CardContainer } from "./SharedStyledComponents"
1212
import Link from "./Link"
1313

1414
import { getLocaleTimestamp } from "../utils/time"
15+
import { trackCustomEvent } from "../utils/matomo"
1516

1617
const Container = styled.div`
1718
margin-top: 2rem;
@@ -342,6 +343,15 @@ const WalletCompare = () => {
342343
selectedFeatureIds.splice(index, 1)
343344
} else {
344345
selectedFeatureIds.push(featureId)
346+
347+
const feature = walletFeatures.filter(
348+
(feature) => feature.id === featureId
349+
)[0].title
350+
trackCustomEvent({
351+
eventCategory: `Wallet feature`,
352+
eventAction: `Selected`,
353+
eventName: feature,
354+
})
345355
}
346356
setState({ selectedFeatureIds, wallets: state.wallets })
347357
}

src/pages-conditional/wallets/find-wallet.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ const FindWalletPage = ({ location, data }) => {
8989
<Page>
9090
<PageMetadata
9191
title="Find an Ethereum Wallet"
92-
description="Find and compare wallets based on the features you want."
92+
description="Find and compare Ethereum wallets based on the features you want."
9393
/>
9494

9595
<HeroContainer>

src/pages-conditional/wallets/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ const WalletsPage = ({ data }) => {
364364
<Page>
365365
<PageMetadata
366366
title="Ethereum wallets"
367-
description="What you need to know to use Ethereum Wallets."
367+
description="What you need to know to use Ethereum wallets."
368368
image={data.ogImage.childImageSharp.fixed.src}
369369
/>
370370
<HeroContent>

src/pages/get-eth.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ const GetETHPage = ({ data }) => {
234234
<Page>
235235
<PageMetadata
236236
title="How to buy ETH"
237-
description="How to get ETH based on where you live and advice on how to look after it"
237+
description="How to buy ETH based on where you live and advice on how to look after it."
238238
/>
239239

240240
<HeroContainer>
@@ -281,8 +281,14 @@ const GetETHPage = ({ data }) => {
281281
All exchanges, wallets and DEXs listed on this page are not
282282
official endorsements, and are provided for informational purposes
283283
only. We add products to this page based on criteria in our{" "}
284-
<Link to="/en/contributing/adding-products/">dapps</Link> {" "}and <Link to="/en/contributing/adding-exchanges/">exchanges</Link> {" "}listing policies.
285-
If you want to add an exchange or provide feedback on the policy{" "} <Link to="https://github.com/ethereum/ethereum-org-website/issues/new/choose">raise an issue in GitHub</Link>.
284+
<Link to="/en/contributing/adding-products/">dapps</Link> and{" "}
285+
<Link to="/en/contributing/adding-exchanges/">exchanges</Link>{" "}
286+
listing policies. If you want to add an exchange or provide
287+
feedback on the policy{" "}
288+
<Link to="https://github.com/ethereum/ethereum-org-website/issues/new/choose">
289+
raise an issue in GitHub
290+
</Link>
291+
.
286292
</em>
287293
</p>
288294
</Content>

0 commit comments

Comments
 (0)