Skip to content

Commit a0c73c3

Browse files
committed
Finish setting up learn hub with translations, and fix a couple console errors
1 parent 63017ba commit a0c73c3

File tree

3 files changed

+43
-18
lines changed

3 files changed

+43
-18
lines changed

src/components/Nav/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ const Nav: React.FC<IProps> = ({ path }) => {
178178
items: [
179179
{
180180
// @ts-ignore: until we add the translations
181-
text: "Learn hub",
181+
text: "hero-title",
182182
to: "/learn/",
183183
},
184184
],

src/intl/en/page-learn.json

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,20 +100,35 @@
100100
"online-communities-card-description": "Online communities provide a great opportunity to ask more specific questions or get involved.",
101101
"online-communities-card-button": "Explore communities",
102102
"books-about-ethereum": "Books about Ethereum and Cryptocurrencies",
103+
"cryptopians-title": "The Cryptopians",
103104
"cryptopians-description": "February 22, 2022 - Laura Shin",
105+
"out-of-the-ether-title": "Out of the Ether",
104106
"out-of-the-ether-description": "September 29, 2020 - Matthew Leising",
107+
"the-infinite-machine-title": "The Infinite Machine",
105108
"the-infinite-machine-description": "July 14, 2020 - Camila Russo",
109+
"the-age-of-cryptocurrency-title": "The Age of Cryptocurrency",
106110
"the-age-of-cryptocurrency-description": "January 12, 2016 - Paul Vigna, Michael J. Casey",
111+
"the-truth-machine-title": "The Truth Machine",
107112
"the-truth-machine-description": "February 27, 2018 - Paul Vigna, Michael J. Casey",
113+
"digital-gold-title": "Digital Gold",
108114
"digital-gold-description": "May 24, 2021 - Nathaniel Popper",
115+
"kings-of-crypto-title": "Kings of Crypto",
109116
"kings-of-crypto-description": "December 15, 2020 - Jeff John Roberts",
117+
"mastering-ethereum-title": "Mastering Ethereum",
110118
"mastering-ethereum-description": "December 23, 2018 – Andreas M. Antonopoulos, Gavin Wood Ph.D.",
111119
"podcasts-about-ethereum": "Podcasts about Ethereum and Cryptocurrencies",
120+
"into-the-ether-title": "Into the Ether",
112121
"ethhub-description": "A podcast focusing on all things Ethereum and DeFi",
122+
"bankless-title": "Bankless",
113123
"bankless-description": "A guide to Crypto finance",
124+
"uncommon-core-title": "Uncommon Core",
114125
"uncommon-core-description": "Explores the transformative nature of trust-minimized currency and financial services",
126+
"zeroknowledge-title": "Zero Knowledge",
115127
"zeroknowledge-description": "Goes deep into the tech that will power the emerging decentralized web and the community building this",
128+
"epicenter-title": "Epicenter",
116129
"epicenter-description": "Explores the technical, economic, and social implications of the Crypto industry",
130+
"unchained-title": "Unchained",
117131
"unchained-description": "Dives deep into the people building the decentralized internet, the details of this technology that could underpin our future, and some of the thorniest topics in crypto, such as regulation, security and privacy",
132+
"into-the-bytecode-title": "Into the Bytecode",
118133
"into-the-bytecode-description": "A podcast about the ideas shaping crypto"
119134
}

src/pages/learn/index.tsx

Lines changed: 27 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ const BannerImage = styled.div`
180180

181181
const Section = styled.section`
182182
margin-top: 6rem;
183-
&:first-child {
183+
&:first-of-type {
184184
margin-top: 0;
185185
}
186186
`
@@ -242,7 +242,7 @@ const LearnPage = ({ data }: PageProps<Queries.LearnPageQuery, Context>) => {
242242
<Container>
243243
<PageMetadata
244244
title={translateMessageId("hero-title", intl)}
245-
description={""}
245+
description={translateMessageId("hero-subtitle", intl)}
246246
/>
247247

248248
<HeroBackground>
@@ -801,63 +801,63 @@ const LearnPage = ({ data }: PageProps<Queries.LearnPageQuery, Context>) => {
801801
<ul>
802802
<li>
803803
<Link to="https://www.goodreads.com/book/show/57356067-the-cryptopians">
804-
The Cryptopians
804+
<Translation id="cryptopians-title" />
805805
</Link>{" "}
806806
<i>
807807
<Translation id="cryptopians-description" />
808808
</i>
809809
</li>
810810
<li>
811811
<Link to="https://www.goodreads.com/book/show/55360267-out-of-the-ether">
812-
Out of the Ether
812+
<Translation id="out-of-the-ether-title" />
813813
</Link>{" "}
814814
<i>
815815
<Translation id="out-of-the-ether-description" />
816816
</i>
817817
</li>
818818
<li>
819819
<Link to="https://www.goodreads.com/en/book/show/50175330-the-infinite-machine">
820-
The Infinite Machine
820+
<Translation id="the-infinite-machine-title" />
821821
</Link>{" "}
822822
<i>
823823
<Translation id="the-infinite-machine-description" />
824824
</i>
825825
</li>
826826
<li>
827827
<Link to="https://www.goodreads.com/en/book/show/22174460-the-age-of-cryptocurrency">
828-
The Age of Cryptocurrency
828+
<Translation id="the-age-of-cryptocurrency-title" />
829829
</Link>{" "}
830830
<i>
831831
<Translation id="the-age-of-cryptocurrency-description" />
832832
</i>
833833
</li>
834834
<li>
835835
<Link to="https://www.goodreads.com/en/book/show/34964890-the-truth-machine">
836-
The Truth Machine
836+
<Translation id="the-truth-machine-title" />
837837
</Link>{" "}
838838
<i>
839839
<Translation id="the-truth-machine-description" />
840840
</i>
841841
</li>
842842
<li>
843843
<Link to="https://www.goodreads.com/book/show/23546676-digital-gold">
844-
Digital Gold
844+
<Translation id="digital-gold-title" />
845845
</Link>{" "}
846846
<i>
847847
<Translation id="digital-gold-description" />
848848
</i>
849849
</li>
850850
<li>
851851
<Link to="https://www.goodreads.com/en/book/show/56274031-kings-of-crypto">
852-
Kings of Crypto
852+
<Translation id="kings-of-crypto-title" />
853853
</Link>{" "}
854854
<i>
855855
<Translation id="kings-of-crypto-description" />
856856
</i>
857857
</li>
858858
<li>
859859
<Link to="https://github.com/ethereumbook/ethereumbook">
860-
Mastering Ethereum
860+
<Translation id="mastering-ethereum-title" />
861861
</Link>{" "}
862862
<i>
863863
<Translation id="mastering-ethereum-description" />{" "}
@@ -869,46 +869,56 @@ const LearnPage = ({ data }: PageProps<Queries.LearnPageQuery, Context>) => {
869869
</h3>
870870
<ul>
871871
<li>
872-
<Link to="https://podcast.ethhub.io/">Into the Ether</Link>{" "}
872+
<Link to="https://podcast.ethhub.io/">
873+
<Translation id="into-the-ether-title" />
874+
</Link>{" "}
873875
<i>
874876
<Translation id="ethhub-description" />
875877
</i>
876878
</li>
877879
<li>
878-
<Link to="http://podcast.banklesshq.com/">Bankless</Link>{" "}
880+
<Link to="http://podcast.banklesshq.com/">
881+
<Translation id="bankless-title" />
882+
</Link>{" "}
879883
<i>
880884
<Translation id="bankless-description" />
881885
</i>
882886
</li>
883887
<li>
884888
<Link to="https://uncommoncore.co/podcast/">
885-
Uncommon Core
889+
<Translation id="uncommon-core-title" />
886890
</Link>{" "}
887891
<i>
888892
<Translation id="uncommon-core-description" />
889893
</i>
890894
</li>
891895
<li>
892-
<Link to="https://www.zeroknowledge.fm/">Zero Knowledge</Link>{" "}
896+
<Link to="https://www.zeroknowledge.fm/">
897+
<Translation id="zeroknowledge-title" />
898+
</Link>{" "}
893899
<i>
894900
<Translation id="zeroknowledge-description" />
895901
</i>
896902
</li>
897903
<li>
898-
<Link to="https://epicenter.tv/">Epicenter</Link>{" "}
904+
<Link to="https://epicenter.tv/">
905+
<Translation id="epicenter-title" />
906+
</Link>{" "}
899907
<i>
900908
<Translation id="epicenter-description" />
901909
</i>
902910
</li>
903911
<li>
904-
<Link to="https://unchainedpodcast.com/">Unchained</Link>{" "}
912+
<Link to="https://unchainedpodcast.com/">
913+
<Translation id="unchained-title" />
914+
</Link>{" "}
905915
<i>
906916
<Translation id="unchained-description" />
907917
</i>
908918
</li>
909919
<li>
910920
<Link to="https://www.intothebytecode.xyz/">
911-
Into the Bytecode
921+
<Translation id="into-the-bytecode-title" />
912922
</Link>{" "}
913923
<i>
914924
<Translation id="into-the-bytecode-description" />

0 commit comments

Comments
 (0)