Skip to content

Commit 752f017

Browse files
committed
chore: suggestions from design review
1 parent de6ed46 commit 752f017

File tree

5 files changed

+17
-14
lines changed

5 files changed

+17
-14
lines changed

src/components/Hero/HomeHero/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const HomeHero = ({ heroImg, className }: HomeHeroProps) => {
2626
<Morpher />
2727
<div className="flex flex-col items-center gap-y-5 lg:max-w-2xl">
2828
<h1 className="font-black">{t("page-index:page-index-title")}</h1>
29-
<p className="max-w-96 text-body-medium">
29+
<p className="max-w-96 text-md text-body-medium lg:text-lg">
3030
{t("page-index:page-index-description")}
3131
</p>
3232
</div>

src/components/Homepage/ValuesMarquee.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ type ItemProps = React.HTMLAttributes<HTMLButtonElement> & {
2323
pairing: Pairing
2424
separatorClass: string
2525
container?: HTMLElement | null
26+
label: string
2627
}
2728

2829
const Item = ({
@@ -31,14 +32,15 @@ const Item = ({
3132
pairing,
3233
separatorClass,
3334
container,
35+
label,
3436
}: ItemProps) => (
3537
<>
3638
<Tooltip
3739
container={container}
3840
content={
3941
<Stack>
4042
<h3 className="text-md text-body-medium dark:text-gray-300">
41-
{pairing.ethereum.label} x {pairing.legacy.label}
43+
{label}
4244
</h3>
4345
<div className="flex flex-col gap-4">
4446
<div className="flex gap-2 text-body-medium">
@@ -57,7 +59,7 @@ const Item = ({
5759
<div className="p-1 text-lg">
5860
<EthGlyphSolid />
5961
</div>
60-
<div className="space-y-2">
62+
<div className="flex flex-col gap-2">
6163
{pairing.ethereum.content.map((line) => (
6264
<p key={line} className="text-sm">
6365
{line}
@@ -110,7 +112,7 @@ const Row = forwardRef<HTMLDivElement, RowProps>(
110112
<div
111113
key={idx}
112114
className={cn(
113-
"flex min-w-fit items-center space-x-10 p-6 motion-reduce:w-full motion-reduce:animate-none motion-reduce:justify-center",
115+
"flex min-w-fit items-center space-x-10 px-6 py-8 motion-reduce:w-full motion-reduce:animate-none motion-reduce:justify-center",
114116
isMobile()
115117
? "group-has-[button:hover]:animate-pause"
116118
: "group-hover:animate-pause",
@@ -167,6 +169,7 @@ const ValuesMarquee = () => {
167169
{pairings.map((pairing) => (
168170
<Item
169171
key={pairing.ethereum.label}
172+
label={pairing.ethereum.label}
170173
container={containerFirst}
171174
pairing={pairing}
172175
separatorClass="bg-accent-a"
@@ -186,6 +189,7 @@ const ValuesMarquee = () => {
186189
{pairings.map((pairing) => (
187190
<Item
188191
key={pairing.legacy.label}
192+
label={pairing.legacy.label}
189193
container={containerSecond}
190194
pairing={pairing}
191195
className="bg-gray-200/20 text-body-medium hover:bg-gray-600 hover:text-white dark:bg-gray-950 dark:text-body"
@@ -196,16 +200,16 @@ const ValuesMarquee = () => {
196200
))}
197201
</Row>
198202

199-
<div className="absolute start-[50%] top-[50%] flex -translate-x-[50%] -translate-y-[50%] items-center overflow-hidden rounded-lg text-xs font-bold">
203+
<div className="absolute start-[50%] top-[50%] flex -translate-x-[50%] -translate-y-[50%] items-center overflow-hidden rounded-lg text-sm font-bold">
200204
<p className="bg-gray-50 px-4 py-1 text-body-medium dark:bg-gray-800 dark:text-gray-200">
201205
{t("page-index-values-legacy")}
202206
</p>
203207

204208
<div
205209
className={cn(
206-
"border-t-[13px] border-t-blue-50 dark:border-t-blue-600",
210+
"border-t-[15px] border-t-blue-50 dark:border-t-blue-600",
207211
"border-r-8 border-r-blue-50 dark:border-r-blue-600",
208-
"border-b-[13px] border-b-gray-50 dark:border-b-gray-800",
212+
"border-b-[15px] border-b-gray-50 dark:border-b-gray-800",
209213
"border-l-8 border-l-gray-50 dark:border-l-gray-800"
210214
)}
211215
/>

src/intl/en/page-index.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@
100100
"page-index-values-privacy-legacy-content-1": "Most apps gather as much of your personal information as possible so that they can target you with tailored marketing.",
101101
"page-index-values-privacy-ethereum-label": "Privacy oriented",
102102
"page-index-values-privacy-ethereum-content-0": "Ethereum community respects privacy. You you have the right to use apps without revealing yourself or your contact information.",
103-
"page-index-values-integration-legacy-label": "Integrated",
103+
"page-index-values-integration-legacy-label": "Fragmented",
104104
"page-index-values-integration-legacy-content-0": "Most apps push you to create separate accounts, making it hard to remember all your login details and registrations.",
105-
"page-index-values-integration-ethereum-label": "Fragmented",
105+
"page-index-values-integration-ethereum-label": "Integrated",
106106
"page-index-values-integration-ethereum-content-0": "With Ethereum you can reuse one account in all apps instead. No individual registrations are needed.",
107107
"page-index-values-decentralization-legacy-label": "Centralized",
108108
"page-index-values-decentralization-legacy-content-0": "Companies are owned by private entrepreneurs and shareholders. They alone exert control over the company and benefit the most from its success.",
@@ -118,4 +118,3 @@
118118
"page-index-values-open-ethereum-label": "Open to all",
119119
"page-index-values-open-ethereum-content-0": "Ethereum is public to all. Anyone can see, use, and improve the code, making it better for everyone."
120120
}
121-

src/pages/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -697,8 +697,8 @@ const HomePage = ({
697697
)}
698698
</div>
699699
</div>
700-
<div className="flex justify-start py-8">
701-
<ButtonLink href="/community/events/" size="lg" className="mx-auto">
700+
<div className="flex py-8 sm:justify-center">
701+
<ButtonLink href="/community/events/" size="lg">
702702
{t("page-index:page-index-events-action")} <ChevronNext />
703703
</ButtonLink>
704704
</div>

tailwind.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,8 @@ const config = {
295295
animation: {
296296
"accordion-down": "accordion-down 0.2s ease-out",
297297
"accordion-up": "accordion-up 0.2s ease-out",
298-
"scroll-left": "scroll-left 25s linear infinite",
299-
"scroll-right": "scroll-right 25s linear infinite",
298+
"scroll-left": "scroll-left 30s linear infinite",
299+
"scroll-right": "scroll-right 30s linear infinite",
300300
},
301301
// Add custom border-radius tailwinds extension for "4xl" as "2rem"
302302
borderRadius: {

0 commit comments

Comments
 (0)