Skip to content

Commit 69be182

Browse files
authored
Merge pull request #7452 from hursittarcan/hursitbranch1998
Ensured article titles/descs are translatable [ShardChainsList]
2 parents f9f092f + 64531b5 commit 69be182

File tree

2 files changed

+13
-28
lines changed

2 files changed

+13
-28
lines changed

src/components/ShardChainsList.tsx

Lines changed: 10 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -15,46 +15,28 @@ const ShardChainsList: React.FC<IProps> = () => {
1515
const intl = useIntl()
1616
const reads: Array<CardListItem> = [
1717
{
18-
title: translateMessageId(
19-
"page-upgrade-article-title-sharding-is-great",
20-
intl
21-
),
22-
description: "Vitalik Buterin",
18+
title: translateMessageId("page-upgrade-article-title-sharding-is-great", intl),
19+
description: translateMessageId("page-upgrade-article-author-vitalik-buterin", intl),
2320
link: "https://vitalik.ca/general/2021/04/07/sharding.html",
2421
},
2522
{
26-
title: translateMessageId(
27-
"page-upgrade-article-title-rollup-roadmap",
28-
intl
29-
),
30-
description: "Vitalik Buterin",
23+
title: translateMessageId("page-upgrade-article-title-rollup-roadmap", intl),
24+
description: translateMessageId("page-upgrade-article-author-vitalik-buterin", intl),
3125
link: "https://ethereum-magicians.org/t/a-rollup-centric-ethereum-roadmap/4698",
3226
},
3327
{
34-
title: translateMessageId(
35-
"page-upgrade-article-title-two-point-oh",
36-
intl
37-
),
38-
description: "Ethos.dev",
28+
title: translateMessageId("page-upgrade-article-title-two-point-oh", intl),
29+
description: translateMessageId("page-upgrade-article-author-ethos-dev", intl),
3930
link: "https://ethos.dev/beacon-chain/",
4031
},
4132
{
42-
title: translateMessageId(
43-
"page-upgrade-article-title-sharding-consensus",
44-
intl
45-
),
46-
description: translateMessageId(
47-
"page-upgrade-article-author-ethereum-foundation",
48-
intl
49-
),
33+
title: translateMessageId("page-upgrade-article-title-sharding-consensus", intl),
34+
description: translateMessageId("page-upgrade-article-author-ethereum-foundation", intl),
5035
link: "https://blog.ethereum.org/2020/03/27/sharding-consensus/",
5136
},
5237
{
53-
title: translateMessageId(
54-
"page-upgrade-article-title-hitchhikers-guide-to-ethereum",
55-
intl
56-
),
57-
description: "Delphi Digital",
38+
title: translateMessageId("page-upgrade-article-title-hitchhikers-guide-to-ethereum", intl),
39+
description: translateMessageId("page-upgrade-article-author-delphi-digital", intl),
5840
link: "https://members.delphidigital.io/reports/the-hitchhikers-guide-to-ethereum",
5941
},
6042
]

src/intl/en/page-upgrades-index.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616
"page-upgrade-article-title-beacon-chain-explainer": "The Beacon Chain Ethereum 2.0 explainer you need to read first",
1717
"page-upgrade-article-title-sharding-consensus": "Sharding consensus",
1818
"page-upgrade-article-author-ethereum-foundation": "Ethereum Foundation",
19+
"page-upgrade-article-author-vitalik-buterin": "Vitalik Buterin",
20+
"page-upgrade-article-author-ethos-dev": "Ethos.dev",
21+
"page-upgrade-article-author-delphi-digital": "Delphi Digital",
1922
"page-upgrade-article-title-sharding-is-great": "Why sharding is great: demystifying the technical properties",
2023
"page-upgrade-article-title-rollup-roadmap": "A rollup-centric roadmap",
2124
"page-upgrade-article-title-hitchhikers-guide-to-ethereum": "The Hitchhikers Guide To Ethereum",

0 commit comments

Comments
 (0)