Merge branch 'dev' into stats-box-grid

Author: wackerow

src/components/PageMetadata.tsx

@@ -4,12 +4,7 @@ import Head from "next/head"
 import { useRouter } from "next/router"
 import { useTranslation } from "next-i18next"
 
-import { DEFAULT_LOCALE, SITE_URL } from "@/lib/constants"
-
-import ogImageDapps from "@/public/doge-computer.png"
-import ogImageDevelopers from "@/public/enterprise-eth.png"
-import ogImageDefault from "@/public/home/hero.png"
-import ogImageUpgrades from "@/public/upgrades/upgrade_doge.png"
+import { SITE_URL } from "@/lib/constants"
 
 type NameMeta = {
   name: string
@@ -44,33 +39,38 @@ const PageMetadata: React.FC<IProps> = ({
   const desc = description || t("site-description")
   const siteTitle = t("site-title")
   const fullTitle = `${title} | ${siteTitle}`
+  const origin = process.env.NEXT_PUBLIC_SITE_URL || SITE_URL // TODO: Remove .env var usage after launch
+
+  // Remove any query params (?) or hash links (#)
+  const path = asPath.replace(/[\?\#].*/, "")
+  const slug = path.split("/")
 
   /* Set canonical URL w/ language path to avoid duplicate content */
   /* e.g. set ethereum.org/about/ to ethereum.org/en/about/ */
-  const canonical = canonicalUrl || join(SITE_URL, DEFAULT_LOCALE, asPath)
-  const url = locale ? join(SITE_URL, locale, asPath) : canonical
+  const url = new URL(join(locale!, path), origin).href
+  const canonical = canonicalUrl || url
 
   /* Set fallback ogImage based on path */
-  let ogImage = ogImageDefault.src
+  let ogImage = "/home/hero.png"
 
-  if (asPath.includes("/developers/")) {
-    ogImage = ogImageDevelopers.src
+  if (slug.includes("developers")) {
+    ogImage = "/enterprise-eth.png"
   }
 
-  if (asPath.includes("/dapps/")) {
-    ogImage = ogImageDapps.src
+  if (slug.includes("dapps")) {
+    ogImage = "/doge-computer.png"
   }
 
-  if (asPath.includes("/roadmap/")) {
-    ogImage = ogImageUpgrades.src
+  if (slug.includes("roadmap")) {
+    ogImage = "/upgrades/upgrade_doge.png"
   }
 
   if (image) {
     ogImage = image
   }
 
-  const ogImageUrl = join(SITE_URL, ogImage)
-  const metadata: Array<Meta> = [
+  const ogImageUrl = new URL(ogImage, origin).href
+  const metadata: Meta[] = [
     { name: `description`, content: desc },
     { name: `image`, content: ogImageUrl },
     { property: `og:title`, content: fullTitle },

src/components/ReleaseBanner.tsx

@@ -66,11 +66,13 @@ const SideNavLink = ({ children, ...props }: LinkProps) => {
 export interface IPropsNavLink {
   item: DeveloperDocsLink
   path: string
+  isTopLevel?: boolean
 }
 
-const NavLink: React.FC<IPropsNavLink> = ({ item, path }) => {
+const NavLink: React.FC<IPropsNavLink> = ({ item, path, isTopLevel }) => {
   const { t } = useTranslation("page-developers-docs")
-  const isLinkInPath = path.includes(item.to) || path.includes(item.path)
+  const isLinkInPath =
+    isTopLevel || path.includes(item.to) || path.includes(item.path)
   const [isOpen, setIsOpen] = useState<boolean>(isLinkInPath)
 
   useEffect(() => {
@@ -115,7 +117,7 @@ const NavLink: React.FC<IPropsNavLink> = ({ item, path }) => {
           key={item.id}
           animate={isOpen ? "open" : "closed"}
           variants={innerLinksVariants}
-          initial="closed"
+          initial={isOpen ? "open" : "closed"}
         >
           {item.items.map((childItem, idx) => (
             <NavLink item={childItem} path={path} key={idx} />
@@ -166,7 +168,7 @@ const SideNav = ({ path }: SideNavProps) => {
       aria-label={t("common:nav-developers-docs")}
     >
       {docLinks.map((item, idx) => (
-        <NavLink item={item} path={path} key={idx} />
+        <NavLink item={item} path={path} key={idx} isTopLevel />
       ))}
     </Box>
   )

src/components/SideNav.tsx

@@ -37,49 +37,47 @@ const Mobile: React.FC<IPropsTableOfContentsMobile> = ({ items, maxDepth }) => {
   }
 
   return (
-    <Show below={lgBp}>
-      {/* TODO: switch `l` to `lg` after UI migration and use `hideBelow` prop */}
-      <Box
-        as="aside"
-        background="background.base"
-        border="1px"
-        borderColor="border"
-        borderRadius="4px"
-        py={2}
-        px={4}
+    <Box
+      hideFrom={lgBp}
+      as="aside"
+      background="background.base"
+      border="1px"
+      borderColor="border"
+      borderRadius="4px"
+      py={2}
+      px={4}
+    >
+      <Flex
+        color="text200"
+        cursor="pointer"
+        alignItems="center"
+        justify="space-between"
+        {...getButtonProps()}
       >
-        <Flex
-          color="text200"
-          cursor="pointer"
-          alignItems="center"
-          justify="space-between"
-          {...getButtonProps()}
-        >
-          <chakra.span flex={1} fontWeight={500}>
-            {t("on-this-page")}
-          </chakra.span>
-          <Icon
-            as={MdExpandMore}
-            transform={isOpen ? "rotate(0)" : "rotate(-90deg)"}
-            boxSize={6}
-            transition="transform .4s"
+        <chakra.span flex={1} fontWeight={500}>
+          {t("on-this-page")}
+        </chakra.span>
+        <Icon
+          as={MdExpandMore}
+          transform={isOpen ? "rotate(0)" : "rotate(-90deg)"}
+          boxSize={6}
+          transition="transform .4s"
+        />
+      </Flex>
+      <Fade
+        in={isOpen}
+        {...getDisclosureProps()}
+        transition={{ enter: { duration: 0.6 } }}
+      >
+        <List {...outerListProps}>
+          <ItemsList
+            items={items}
+            depth={0}
+            maxDepth={maxDepth ? maxDepth : 1}
           />
-        </Flex>
-        <Fade
-          in={isOpen}
-          {...getDisclosureProps()}
-          transition={{ enter: { duration: 0.6 } }}
-        >
-          <List {...outerListProps}>
-            <ItemsList
-              items={items}
-              depth={0}
-              maxDepth={maxDepth ? maxDepth : 1}
-            />
-          </List>
-        </Fade>
-      </Box>
-    </Show>
+        </List>
+      </Fade>
+    </Box>
   )
 }