fix: use anchor for hash links over next/link

wackerow · wackerow · commit 2c3bec2e78b1 · 2024-07-29T13:38:43.000-07:00
fixes skipnav navigation bug
diff --git a/tailwind/Link.tsx b/tailwind/Link.tsx
@@ -139,7 +139,7 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
 
   if (isHash) {
     return (
-      <NextLink
+      <a
         onClick={(e) => {
           e.stopPropagation()
           trackCustomEvent(
@@ -154,7 +154,7 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(
         {...commonProps}
       >
         {children}
-      </NextLink>
+      </a>
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(`
`139`	`139`
`140`	`140`	`if (isHash) {`
`141`	`141`	`return (`
`142`		`- <NextLink`
	`142`	`+ <a`
`143`	`143`	`onClick={(e) => {`
`144`	`144`	`e.stopPropagation()`
`145`	`145`	`trackCustomEvent(`
`@@ -154,7 +154,7 @@ export const BaseLink = forwardRef<HTMLAnchorElement, LinkProps>(function Link(`
`154`	`154`	`{...commonProps}`
`155`	`155`	`>`
`156`	`156`	`{children}`
`157`		`- </NextLink>`
	`157`	`+ </a>`
`158`	`158`	`)`
`159`	`159`	`}`
`160`	`160`