Skip to content

Commit 136ccde

Browse files
style(Hero): remove unneeded spacing override for breadcrumbs
1 parent 700bb5b commit 136ccde

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

src/components/Hero/ContentHero/index.tsx

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,7 @@ const ContentHero = (props: ContentHeroProps) => {
2727
/>
2828
</Box>
2929
<Stack p={{ base: "8", lg: "16" }} spacing="9" justify="center">
30-
{/* TODO:
31-
* Recommend the Breadcrumbs component
32-
* not have a spacing style (`mb`) and
33-
* let the parent handle the spacing.
34-
*
35-
* This change would be done when the component is applied
36-
* to prod.
37-
*/}
38-
<Breadcrumbs {...breadcrumbs} mb="0" />
30+
<Breadcrumbs {...breadcrumbs} />
3931
<Stack spacing="6">
4032
<Heading as="h1" size="2xl">
4133
{title}

src/components/Hero/MdxHero/index.tsx

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,7 @@ const MdxHero = (props: MdxHeroProps) => {
1111
const { breadcrumbs, title } = props
1212
return (
1313
<Stack py="8" px="6" spacing="6" w="full">
14-
{/* TODO:
15-
* Recommend the Breadcrumbs component
16-
* not have a spacing style (`mb`) and
17-
* let the parent handle the spacing.
18-
*
19-
* This change would be done when the component is applied
20-
* to prod.
21-
*/}
22-
<Breadcrumbs {...breadcrumbs} mb={0} />
14+
<Breadcrumbs {...breadcrumbs} />
2315
<Heading as="h1" size="2xl">
2416
{title}
2517
</Heading>

0 commit comments

Comments
 (0)