-
Notifications
You must be signed in to change notification settings - Fork 29
MLP tutorials update #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MLP tutorials update #209
Conversation
preview available: https://docs.tds.cscs.ch/209 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpicks (they can be accepted/rejected from the GitHub UI), but otherwise LGTM.
I think it is good to switch from console
to bash
in most cases (bash
should not have the shell prompt $
), but console
should be preferred when there is a mix of commands and output (commands need the prompt $
) or when it is important to show the prompt modification (as in virtual environments).
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
1 similar comment
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
2 similar comments
preview available: https://docs.tds.cscs.ch/209 |
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
…mention login-node policies
preview available: https://docs.tds.cscs.ch/209 |
preview available: https://docs.tds.cscs.ch/209 |
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
preview available: https://docs.tds.cscs.ch/209 |
As discussed with @RMeli, I've reverted the bash blocks to console and made explicit where a command is run by adding the hostname and possibly virtual environment to the shell prompt. I've also added a paragraph about the login node policy. |
This updates the existing MLP tutorials, to be merged with ML software in a next step. Also for the future, a Megatron-LM tutorial with recommended settings is left.