Skip to content

Commit dccc1e8

Browse files
authored
Merge pull request #239 from estesp/fix-image-gen-again
Fix Alpine+credential helpers image generation (again)
2 parents 56b94e8 + 9e05969 commit dccc1e8

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

hack/Dockerfile.alpine

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ ARG TARGETPLATFORM
33
ARG TARGETARCH
44
ARG TARGETVARIANT
55
ARG BUILDPLATFORM
6+
ARG BUILDARCH
67
RUN apk add bash git
78

89
ENV GOOS linux
@@ -17,17 +18,18 @@ RUN GOARM=${GOARMV#v} go install github.com/awslabs/amazon-ecr-credential-helper
1718
# Get ACR docker env credential helper
1819
RUN GOARM=${GOARMV#v} go install github.com/chrismellard/docker-credential-acr-env@latest
1920

21+
RUN if [ ! "${BUILDARCH}" = "${TARGETARCH}" ]; then mv /go/bin/linux_${TARGETARCH}/* /go/bin; fi
22+
2023
RUN mkdir /manifest-tool
2124
WORKDIR /manifest-tool
2225
COPY . /manifest-tool
2326
RUN /manifest-tool/hack/makestatic.sh $TARGETARCH ${TARGETVARIANT#v}
2427

2528
FROM --platform=$TARGETPLATFORM alpine:3.17.0
26-
ARG TARGETARCH
2729
COPY --from=bld /manifest-tool/manifest-tool /manifest-tool
2830
COPY --from=bld /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
29-
COPY --from=bld --chown=0:0 /go/bin/linux_${TARGETARCH}/docker-credential-gcr /usr/bin/docker-credential-gcloud
30-
COPY --from=bld --chown=0:0 /go/bin/linux_${TARGETARCH}/docker-credential-ecr-login /usr/bin/docker-credential-ecr-login
31-
COPY --from=bld --chown=0:0 /go/bin/linux_${TARGETARCH}/docker-credential-acr-env /usr/bin/docker-credential-acr-env
31+
COPY --from=bld --chown=0:0 /go/bin/docker-credential-gcr /usr/bin/docker-credential-gcloud
32+
COPY --from=bld --chown=0:0 /go/bin/docker-credential-ecr-login /usr/bin/docker-credential-ecr-login
33+
COPY --from=bld --chown=0:0 /go/bin/docker-credential-acr-env /usr/bin/docker-credential-acr-env
3234
ENV PATH="${PATH}:/"
3335
ENTRYPOINT [ "/manifest-tool" ]

v2/cmd/manifest-tool/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
var gitCommit = ""
1515

1616
const (
17-
version = "2.1.1"
17+
version = "2.1.2"
1818
usage = "registry client to inspect and push multi-platform OCI & Docker v2 images"
1919
)
2020

0 commit comments

Comments
 (0)