Merge pull request #658 from Ant2000/master

david-cermak · web-flow · commit 6f90d8593398 · 2024-09-18T11:14:30.000+02:00
[modem] Minor change to exit_cmux behavior
diff --git a/components/esp_modem/src/esp_modem_dte.cpp b/components/esp_modem/src/esp_modem_dte.cpp
@@ -156,12 +156,10 @@ bool DTE::exit_cmux()
     if (!cmux_term) {
         return false;
     }
-    if (!cmux_term->deinit()) {
-        return false;
-    }
+    const bool success = cmux_term->deinit();
     exit_cmux_internal();
     cmux_term.reset();
-    return true;
+    return success;
 }
 
 void DTE::exit_cmux_internal()

Original file line number	Diff line number	Diff line change
`@@ -156,12 +156,10 @@ bool DTE::exit_cmux()`
`156`	`156`	`if (!cmux_term) {`
`157`	`157`	`return false;`
`158`	`158`	`}`
`159`		`- if (!cmux_term->deinit()) {`
`160`		`- return false;`
`161`		`- }`
	`159`	`+ const bool success = cmux_term->deinit();`
`162`	`160`	`exit_cmux_internal();`
`163`	`161`	`cmux_term.reset();`
`164`		`- return true;`
	`162`	`+ return success;`
`165`	`163`	`}`
`166`	`164`
`167`	`165`	`void DTE::exit_cmux_internal()`