Skip to content

Commit 24f55ce

Browse files
committed
fix(mdns): Fixed potential out-of-bound interface error
invalid mdns_if was handled for enabling/announcing pcbs, but not for the consequent browsing Closes coverity isssue: 470162 Out-of-bounds access
1 parent 8f8516c commit 24f55ce

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

components/mdns/mdns.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4479,10 +4479,11 @@ void mdns_preset_if_handle_system_event(void *arg, esp_event_base_t event_base,
44794479
case IP_EVENT_GOT_IP6: {
44804480
ip_event_got_ip6_t *event = (ip_event_got_ip6_t *) event_data;
44814481
mdns_if_t mdns_if = _mdns_get_if_from_esp_netif(event->esp_netif);
4482-
if (mdns_if < MDNS_MAX_INTERFACES) {
4483-
post_mdns_enable_pcb(mdns_if, MDNS_IP_PROTOCOL_V6);
4484-
post_mdns_announce_pcb(mdns_if, MDNS_IP_PROTOCOL_V4);
4482+
if (mdns_if >= MDNS_MAX_INTERFACES) {
4483+
return;
44854484
}
4485+
post_mdns_enable_pcb(mdns_if, MDNS_IP_PROTOCOL_V6);
4486+
post_mdns_announce_pcb(mdns_if, MDNS_IP_PROTOCOL_V4);
44864487
mdns_browse_t *browse = _mdns_server->browse;
44874488
while (browse) {
44884489
_mdns_browse_send(browse, mdns_if);

0 commit comments

Comments
 (0)