Skip to content

fix: update pypi release process #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

mfialaf
Copy link
Collaborator

@mfialaf mfialaf commented Apr 29, 2025

Replacing tag latest with 24.04 ensures release process will not break again when certain python version is not present in latest ubuntu version.

Publish_pypi job changes:

  • Use fixed version of ubuntu - 24.04
  • Update python to 3.13
  • Set stable version of actions/setup-python and actions/checkout

@mfialaf mfialaf self-assigned this Apr 29, 2025
@mfialaf mfialaf force-pushed the fix/update_pypi_release_process branch 2 times, most recently from 36c2a55 to d4c3a4e Compare April 29, 2025 08:59
@mfialaf mfialaf marked this pull request as ready for review April 29, 2025 09:02
Copy link
Collaborator

@peterdragun peterdragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Replacing tag `latest` with `24.04` ensures release procees
will not break again when certain python version is not
present in latest ubuntu version.

Same applies for stable versions for
actions/checkout and actions/setup-python.
@mfialaf mfialaf force-pushed the fix/update_pypi_release_process branch from d4c3a4e to 6fb9d4e Compare April 29, 2025 13:55
@mfialaf
Copy link
Collaborator Author

mfialaf commented Apr 29, 2025

I updated the actions/checkout and actions/setup-python, to the latest stable versions instead of master.
Also python is 3.13 now.

@dobairoland @peterdragun PTAL again.

P.S Same setting is done in esp-idf-monitor.

@mfialaf mfialaf changed the title Fix/update pypi release process fix: update pypi release process Apr 29, 2025
Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfialaf!

@mfialaf mfialaf merged commit 5be2309 into master Apr 30, 2025
@dobairoland dobairoland deleted the fix/update_pypi_release_process branch April 30, 2025 13:30
@dobairoland
Copy link
Collaborator

@mfialaf Please don't forget to delete the branches after merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants