-
Notifications
You must be signed in to change notification settings - Fork 6
fix: update pypi release process #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
36c2a55
to
d4c3a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replacing tag `latest` with `24.04` ensures release procees will not break again when certain python version is not present in latest ubuntu version. Same applies for stable versions for actions/checkout and actions/setup-python.
d4c3a4e
to
6fb9d4e
Compare
I updated the @dobairoland @peterdragun PTAL again. P.S Same setting is done in esp-idf-monitor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mfialaf!
@mfialaf Please don't forget to delete the branches after merge. |
Replacing tag
latest
with24.04
ensures release process will not break again when certain python version is not present in latest ubuntu version.Publish_pypi job changes:
actions/setup-python
andactions/checkout