Implement cmd default response handler

Author: P-R-O-C-H-Y

libraries/Zigbee/src/Zigbee_ep.cpp

@@ -47,10 +47,13 @@ void Zigbee_EP::setManufacturerAndModel(const char *name, const char *model) {
     memcpy(zb_model + 1, model, length);
     zb_model[length + 1] = '\0';
 
+    // Get the basic cluster and update the manufacturer and model attributes
     esp_zb_attribute_list_t *basic_cluster = esp_zb_cluster_list_get_cluster(_cluster_list, ESP_ZB_ZCL_CLUSTER_ID_BASIC, ESP_ZB_ZCL_CLUSTER_SERVER_ROLE);
     esp_zb_basic_cluster_add_attr(basic_cluster, ESP_ZB_ZCL_ATTR_BASIC_MANUFACTURER_NAME_ID, (void *)zb_name);
     esp_zb_basic_cluster_add_attr(basic_cluster, ESP_ZB_ZCL_ATTR_BASIC_MODEL_IDENTIFIER_ID, (void *)zb_model);
 
+    //NOTE:
+    // esp_zb_cluster_add_attr function
 }
 
 void Zigbee_EP::readManufacturerAndModel(uint8_t endpoint, uint16_t short_addr) {
@@ -95,5 +98,3 @@ void Zigbee_EP::attribute_read_cmd(uint16_t cluster_id, const esp_zb_zcl_attribu
         }
     }
 }
-//NOTE:
-// esp_zb_cluster_add_attr function

libraries/Zigbee/src/Zigbee_handlers.cpp

@@ -6,21 +6,20 @@
 static esp_err_t zb_attribute_set_handler(const esp_zb_zcl_set_attr_value_message_t *message);
 static esp_err_t zb_attribute_reporting_handler(const esp_zb_zcl_report_attr_message_t *message);
 static esp_err_t zb_cmd_read_attr_resp_handler(const esp_zb_zcl_cmd_read_attr_resp_message_t *message);
+static esp_err_t zb_cmd_default_resp_handler(esp_zb_zcl_cmd_default_resp_message_t *message);
 
 // Zigbee action handlers
 static esp_err_t zb_action_handler(esp_zb_core_action_callback_id_t callback_id, const void *message) {
   esp_err_t ret = ESP_OK;
   /* TODO: 
-    Implement handlers for different Zigbee actions (callback_id's)
+    Implement handlers for different Zigbee actions (callback_id's) here and call the respective EP's method
   */
-  // NOTE: Implement all Zigbee actions that can be handled by the Zigbee_Core class, or just call user defined callback function and let the user handle the action and read the message properly
-  // NOTE: This may me harder for users, to know what callback_id's are available and what message type is received
   switch (callback_id) {
     case ESP_ZB_CORE_SET_ATTR_VALUE_CB_ID:          ret = zb_attribute_set_handler((esp_zb_zcl_set_attr_value_message_t *)message); break;
     case ESP_ZB_CORE_REPORT_ATTR_CB_ID:             ret = zb_attribute_reporting_handler((esp_zb_zcl_report_attr_message_t *)message); break;
     case ESP_ZB_CORE_CMD_READ_ATTR_RESP_CB_ID:      ret = zb_cmd_read_attr_resp_handler((esp_zb_zcl_cmd_read_attr_resp_message_t *)message); break;
     // case ESP_ZB_CORE_CMD_REPORT_CONFIG_RESP_CB_ID:  ret = zb_configure_report_resp_handler((esp_zb_zcl_cmd_config_report_resp_message_t *)message); break;
-    case ESP_ZB_CORE_CMD_DEFAULT_RESP_CB_ID:        log_i("Received default response"); break;
+    case ESP_ZB_CORE_CMD_DEFAULT_RESP_CB_ID:        ret = zb_cmd_default_resp_handler((esp_zb_zcl_cmd_default_resp_message_t *)message); break;
     default:                                 log_w("Receive unhandled Zigbee action(0x%x) callback", callback_id); break;
   }
   return ret;
@@ -34,7 +33,7 @@ static esp_err_t zb_attribute_set_handler(const esp_zb_zcl_set_attr_value_messag
     log_e("Received message: error status(%d)", message->info.status);
   }
 
-  log_i(
+  log_v(
     "Received message: endpoint(%d), cluster(0x%x), attribute(0x%x), data size(%d)", message->info.dst_endpoint, message->info.cluster, message->attribute.id,
     message->attribute.data.size
   );
@@ -55,7 +54,7 @@ static esp_err_t zb_attribute_reporting_handler(const esp_zb_zcl_report_attr_mes
   if (message->status != ESP_ZB_ZCL_STATUS_SUCCESS) {
     log_e("Received message: error status(%d)", message->status);
   }
-  log_i(
+  log_v(
     "Received report from address(0x%x) src endpoint(%d) to dst endpoint(%d) cluster(0x%x)", message->src_address.u.short_addr, message->src_endpoint,
     message->dst_endpoint, message->cluster
   );
@@ -75,7 +74,7 @@ static esp_err_t zb_cmd_read_attr_resp_handler(const esp_zb_zcl_cmd_read_attr_re
   if (message->info.status != ESP_ZB_ZCL_STATUS_SUCCESS) {
     log_e("Received message: error status(%d)", message->info.status);
   }
-  log_i(
+  log_v(
     "Read attribute response: from address(0x%x) src endpoint(%d) to dst endpoint(%d) cluster(0x%x)", message->info.src_address.u.short_addr,
     message->info.src_endpoint, message->info.dst_endpoint, message->info.cluster
   );
@@ -84,7 +83,7 @@ static esp_err_t zb_cmd_read_attr_resp_handler(const esp_zb_zcl_cmd_read_attr_re
     if (message->info.dst_endpoint == (*it)->_endpoint) {
       esp_zb_zcl_read_attr_resp_variable_t *variable = message->variables;
       while (variable) {
-        log_i(
+        log_v(
           "Read attribute response: status(%d), cluster(0x%x), attribute(0x%x), type(0x%x), value(%d)", variable->status, message->info.cluster,
           variable->attribute.id, variable->attribute.data.type, variable->attribute.data.value ? *(uint8_t *)variable->attribute.data.value : 0
         );
@@ -98,3 +97,17 @@ static esp_err_t zb_cmd_read_attr_resp_handler(const esp_zb_zcl_cmd_read_attr_re
   }
   return ESP_OK;
 }
+
+static esp_err_t zb_cmd_default_resp_handler(esp_zb_zcl_cmd_default_resp_message_t *message) {
+  if (!message) {
+    log_e("Empty message");
+  }
+  if (message->info.status != ESP_ZB_ZCL_STATUS_SUCCESS) {
+    log_e("Received message: error status(%d)", message->info.status);
+  }
+  log_v(
+    "Received default response: from address(0x%x), src_endpoint(%d) to dst_endpoint(%d), cluster(0x%x) with status 0x%x", message->info.src_address.u.short_addr,
+    message->info.src_endpoint, message->info.dst_endpoint, message->info.cluster, message->status_code
+  );
+  return ESP_OK;
+}