Merge pull request espressif#409 from zwx1995esp/fix/mdns_host_name_get

gabsuren · web-flow · commit ebdac9cc01a0 · 2023-11-01T13:25:15.000+04:00
fix(mdns): add terminator for the getting host name
diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c
@@ -5613,7 +5613,9 @@ esp_err_t mdns_hostname_get(char *hostname)
     }
 
     MDNS_SERVICE_LOCK();
-    strncpy(hostname, _mdns_server->hostname, strnlen(_mdns_server->hostname, MDNS_NAME_BUF_LEN));
+    size_t len = strnlen(_mdns_server->hostname, MDNS_NAME_BUF_LEN - 1);
+    strncpy(hostname, _mdns_server->hostname, len);
+    hostname[len] = 0;
     MDNS_SERVICE_UNLOCK();
     return ESP_OK;
 }

Original file line number	Diff line number	Diff line change
`@@ -5613,7 +5613,9 @@ esp_err_t mdns_hostname_get(char *hostname)`
`5613`	`5613`	`}`
`5614`	`5614`
`5615`	`5615`	`MDNS_SERVICE_LOCK();`
`5616`		`- strncpy(hostname, _mdns_server->hostname, strnlen(_mdns_server->hostname, MDNS_NAME_BUF_LEN));`
	`5616`	`+ size_t len = strnlen(_mdns_server->hostname, MDNS_NAME_BUF_LEN - 1);`
	`5617`	`+ strncpy(hostname, _mdns_server->hostname, len);`
	`5618`	`+ hostname[len] = 0;`
`5617`	`5619`	`MDNS_SERVICE_UNLOCK();`
`5618`	`5620`	`return ESP_OK;`
`5619`	`5621`	`}`