Skip to content

Commit 2e67328

Browse files
authored
Merge pull request espressif#391 from david-cermak/fix/modem_usb_dte
[esp-modem]: Added USB runner with ESP32S2 with A7670
2 parents d7d2490 + edeb936 commit 2e67328

File tree

3 files changed

+25
-3
lines changed

3 files changed

+25
-3
lines changed

.github/workflows/modem__target-test.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ jobs:
1616
idf_ver: ["latest"]
1717
idf_target: ["esp32c3"]
1818
test: [ { app: pppd, path: test/target }, { app: sim800_c3, path: examples/pppos_client }, { app: sim800_cmux, path: examples/simple_cmux_client } ]
19+
include:
20+
- idf_ver: "latest"
21+
idf_target: "esp32s2"
22+
test: { app: usb_a7670_s2, path: examples/pppos_client }
1923
runs-on: ubuntu-20.04
2024
container: espressif/idf:${{ matrix.idf_ver }}
2125
env:
@@ -55,6 +59,10 @@ jobs:
5559
idf_ver: ["latest"]
5660
idf_target: ["esp32c3"]
5761
test: [ { app: pppd, path: test/target }, { app: sim800_c3, path: examples/pppos_client }, { app: sim800_cmux, path: examples/simple_cmux_client } ]
62+
include:
63+
- idf_ver: "latest"
64+
idf_target: "esp32s2"
65+
test: { app: usb_a7670_s2, path: examples/pppos_client }
5866
needs: build_esp_modem_tests
5967
runs-on:
6068
- self-hosted
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
CONFIG_IDF_TARGET="esp32s2"
2+
# Override some defaults to enable PPP
3+
CONFIG_LWIP_PPP_SUPPORT=y
4+
CONFIG_LWIP_PPP_NOTIFY_PHASE_SUPPORT=y
5+
CONFIG_LWIP_PPP_PAP_SUPPORT=y
6+
CONFIG_LWIP_TCPIP_TASK_STACK_SIZE=4096
7+
CONFIG_LWIP_PPP_ENABLE_IPV6=n
8+
CONFIG_EXAMPLE_SERIAL_CONFIG_USB=y
9+
CONFIG_EXAMPLE_MODEM_DEVICE_A7670=y
10+
CONFIG_EXAMPLE_MODEM_PPP_APN="lpwa.vodafone.com"
11+
CONFIG_EXAMPLE_MODEM_PPP_AUTH_NONE=y
12+
CONFIG_EXAMPLE_MQTT_TEST_TOPIC="/ci/esp-modem/pppos-client"
13+
CONFIG_ESP_SYSTEM_PANIC_PRINT_HALT=y
14+
CONFIG_ESP32_PANIC_PRINT_HALT=y

components/esp_modem/src/esp_modem_dte.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ void DTE::set_command_callbacks()
7878
if (command_cb.process_line(data, 0, len)) {
7979
return true;
8080
}
81-
// cannot inflate and the processing hasn't finishes in the first iteration -> report a failure
82-
command_cb.give_up();
83-
return true;
81+
// cannot inflate and the processing hasn't finishes in the first iteration, but continue
82+
// (will post next fragments to the parser, since we might be just missing a last token or OK
83+
return false;
8484
#endif
8585
}
8686
// data == nullptr: Terminals which request users to read current data

0 commit comments

Comments
 (0)