remove (std::nothrow) where nullptr case is not handled

remove legacy new management

Author: d-a-v

boards.txt

@@ -7,7 +7,7 @@ typedef void (*voidFuncPtr)(void);
 typedef void (*voidFuncPtrArg)(void*);
 
 // Helper functions for Functional interrupt routines
-extern "C" bool __attachInterruptFunctionalArg(uint8_t pin, voidFuncPtr userFunc, void*fp, int mode, bool functional);
+extern "C" void __attachInterruptFunctionalArg(uint8_t pin, voidFuncPtr userFunc, void*fp, int mode, bool functional);
 
 
 void ICACHE_RAM_ATTR interruptFunctional(void* arg)
@@ -34,52 +34,32 @@ extern "C"
    }
 }
 
-bool attachInterrupt(uint8_t pin, std::function<void(void)> intRoutine, int mode)
+void attachInterrupt(uint8_t pin, std::function<void(void)> intRoutine, int mode)
 {
 	// use the local interrupt routine which takes the ArgStructure as argument
 
 	InterruptInfo* ii = nullptr;
 
-	FunctionInfo* fi = new (std::nothrow) FunctionInfo;
-	if (fi == nullptr)
-	    return false;
+	FunctionInfo* fi = new FunctionInfo;
 	fi->reqFunction = intRoutine;
 
-	ArgStructure* as = new (std::nothrow) ArgStructure;
-    if (as == nullptr)
-    {
-        delete(fi);
-        return false;
-    }
+	ArgStructure* as = new ArgStructure;
 	as->interruptInfo = ii;
 	as->functionInfo = fi;
 
-	return __attachInterruptFunctionalArg(pin, (voidFuncPtr)interruptFunctional, as, mode, true);
+	__attachInterruptFunctionalArg(pin, (voidFuncPtr)interruptFunctional, as, mode, true);
 }
 
-bool attachScheduledInterrupt(uint8_t pin, std::function<void(InterruptInfo)> scheduledIntRoutine, int mode)
+void attachScheduledInterrupt(uint8_t pin, std::function<void(InterruptInfo)> scheduledIntRoutine, int mode)
 {
-	InterruptInfo* ii = new (std::nothrow) InterruptInfo;
-	if (ii == nullptr)
-	    return false;
+	InterruptInfo* ii = new InterruptInfo;
 
 	FunctionInfo* fi = new FunctionInfo;
-	if (fi == nullptr)
-	{
-	    delete ii;
-	    return false;
-	}
 	fi->reqScheduledFunction = scheduledIntRoutine;
 
-	ArgStructure* as = new (std::nothrow) ArgStructure;
-	if (as == nullptr)
-	{
-	    delete ii;
-	    delete fi;
-	    return false;
-	}
+	ArgStructure* as = new ArgStructure;
 	as->interruptInfo = ii;
 	as->functionInfo = fi;
 
-	return __attachInterruptFunctionalArg(pin, (voidFuncPtr)interruptFunctional, as, mode, true);
+	__attachInterruptFunctionalArg(pin, (voidFuncPtr)interruptFunctional, as, mode, true);
 }

cores/esp8266/FunctionalInterrupt.cpp

@@ -28,8 +28,8 @@ struct ArgStructure {
 	FunctionInfo* functionInfo = nullptr;
 };
 
-bool attachInterrupt(uint8_t pin, std::function<void(void)> intRoutine, int mode);
-bool attachScheduledInterrupt(uint8_t pin, std::function<void(InterruptInfo)> scheduledIntRoutine, int mode);
+void attachInterrupt(uint8_t pin, std::function<void(void)> intRoutine, int mode);
+void attachScheduledInterrupt(uint8_t pin, std::function<void(InterruptInfo)> scheduledIntRoutine, int mode);
 
 
 #endif //INTERRUPTS_H

cores/esp8266/FunctionalInterrupt.h

@@ -182,7 +182,7 @@ bool UpdaterClass::begin(size_t size, int command, int ledPin, uint8_t ledOn) {
   } else {
     _bufferSize = 256;
   }
-  _buffer = new (std::nothrow) uint8_t[_bufferSize];
+  _buffer = new uint8_t[_bufferSize];
   _command = command;
 
 #ifdef DEBUG_UPDATER

cores/esp8266/Updater.cpp

@@ -106,9 +106,9 @@ void ArduinoOTAClass::setRebootOnSuccess(bool reboot){
   _rebootOnSuccess = reboot;
 }
 
-bool ArduinoOTAClass::begin(bool useMDNS) {
+void ArduinoOTAClass::begin(bool useMDNS) {
   if (_initialized)
-    return true;
+    return;
 
   _useMDNS = useMDNS;
 
@@ -126,13 +126,11 @@ bool ArduinoOTAClass::begin(bool useMDNS) {
     _udp_ota = 0;
   }
 
-  _udp_ota = new (std::nothrow) UdpContext;
-  if (_udp_ota == nullptr)
-    return false;
+  _udp_ota = new UdpContext;
   _udp_ota->ref();
 
   if(!_udp_ota->listen(IP_ADDR_ANY, _port))
-    return false;
+    return;
   _udp_ota->onRx(std::bind(&ArduinoOTAClass::_onRx, this));
 
 #if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_MDNS)
@@ -151,7 +149,6 @@ bool ArduinoOTAClass::begin(bool useMDNS) {
 #ifdef OTA_DEBUG
   OTA_DEBUG.printf("OTA server at: %s.local:%u\n", _hostname.c_str(), _port);
 #endif
-  return true;
 }
 
 int ArduinoOTAClass::parseInt(){

libraries/ArduinoOTA/ArduinoOTA.cpp

@@ -60,7 +60,7 @@ class ArduinoOTAClass
     void onProgress(THandlerFunction_Progress fn);
 
     //Starts the ArduinoOTA service
-    bool begin(bool useMDNS = true);
+    void begin(bool useMDNS = true);
 
     //Call this in loop() to run the service. Also calls MDNS.update() when begin() or begin(true) is used.
     void handle();

libraries/ArduinoOTA/ArduinoOTA.h

@@ -64,12 +64,9 @@ void EEPROMClass::begin(size_t size) {
   //In case begin() is called a 2nd+ time, don't reallocate if size is the same
   if(_data && size != _size) {
     delete[] _data;
-    _data = new (std::nothrow) uint8_t[size];
+    _data = new uint8_t[size];
   } else if(!_data) {
-    _data = new (std::nothrow) uint8_t[size];
-  }
-  if (_data == nullptr) {
-    return;
+    _data = new uint8_t[size];
   }
 
   _size = size;

libraries/EEPROM/EEPROM.cpp

@@ -41,10 +41,7 @@ void loop() {
   // wait for WiFi connection
   if ((WiFiMulti.run() == WL_CONNECTED)) {
 
-    std::unique_ptr<BearSSL::WiFiClientSecure>client(new (std::nothrow) BearSSL::WiFiClientSecure);
-    if (client == nullptr) {
-      return;
-    }
+    std::unique_ptr<BearSSL::WiFiClientSecure>client(new BearSSL::WiFiClientSecure);
 
     client->setFingerprint(fingerprint);
 

libraries/ESP8266HTTPClient/examples/BasicHttpsClient/BasicHttpsClient.ino

@@ -38,10 +38,7 @@ void loop() {
   // wait for WiFi connection
   if ((WiFiMulti.run() == WL_CONNECTED)) {
 
-    std::unique_ptr<BearSSL::WiFiClientSecure> client(new (std::nothrow) BearSSL::WiFiClientSecure);
-    if (client == nullptr) {
-      return;
-    }
+    std::unique_ptr<BearSSL::WiFiClientSecure> client(new BearSSL::WiFiClientSecure);
 
     bool mfln = client->probeMaxFragmentLength("tls.mbed.org", 443, 1024);
     Serial.printf("\nConnecting to https://tls.mbed.org\n");

libraries/ESP8266HTTPClient/examples/StreamHttpsClient/StreamHttpsClient.ino

@@ -37,7 +37,7 @@ class TransportTraits
 
     virtual std::unique_ptr<WiFiClient> create()
     {
-        return std::unique_ptr<WiFiClient>(new (std::nothrow) WiFiClient());
+        return std::unique_ptr<WiFiClient>(new WiFiClient());
     }
 
     virtual bool verify(WiFiClient& client, const char* host)
@@ -59,9 +59,8 @@ class BearSSLTraits : public TransportTraits
 
     std::unique_ptr<WiFiClient> create() override
     {
-        BearSSL::WiFiClientSecure *client = new (std::nothrow) BearSSL::WiFiClientSecure();
-        if (client != nullptr)
-            client->setFingerprint(_fingerprint);
+        BearSSL::WiFiClientSecure *client = new BearSSL::WiFiClientSecure();
+        client->setFingerprint(_fingerprint);
         return std::unique_ptr<WiFiClient>(client);
     }
 
@@ -213,8 +212,8 @@ bool HTTPClient::begin(String url)
     if (!beginInternal(url, "http")) {
         return false;
     }
-    _transportTraits = TransportTraitsPtr(new (std::nothrow) TransportTraits());
-    return _transportTraits != nullptr;
+    _transportTraits = TransportTraitsPtr(new TransportTraits());
+    return true;
 }
 
 
@@ -291,9 +290,9 @@ bool HTTPClient::begin(String host, uint16_t port, String uri)
     _host = host;
     _port = port;
     _uri = uri;
-    _transportTraits = TransportTraitsPtr(new (std::nothrow) TransportTraits());
+    _transportTraits = TransportTraitsPtr(new TransportTraits());
     DEBUG_HTTPCLIENT("[HTTP-Client][begin] host: %s port: %d uri: %s\n", host.c_str(), port, uri.c_str());
-    return _transportTraits != nullptr;
+    return true;
 }
 
 
@@ -310,13 +309,13 @@ bool HTTPClient::begin(String host, uint16_t port, String uri, const uint8_t htt
     _port = port;
     _uri = uri;
 
-    _transportTraits = TransportTraitsPtr(new (std::nothrow) BearSSLTraits(httpsFingerprint));
+    _transportTraits = TransportTraitsPtr(new BearSSLTraits(httpsFingerprint));
     DEBUG_HTTPCLIENT("[HTTP-Client][begin] host: %s port: %d url: %s BearSSL-httpsFingerprint:", host.c_str(), port, uri.c_str());
     for (size_t i=0; i < 20; i++) {
         DEBUG_HTTPCLIENT(" %02x", httpsFingerprint[i]);
     }
     DEBUG_HTTPCLIENT("\n");
-    return _transportTraits != nullptr;
+    return true;
 }