Fix compilation

Author: thetek42

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 - `save-image` now checks if the ELF contains the app descriptor (#920)
+- Add support for secure padding for save-image (#876)
 
 ### Changed
 
@@ -48,7 +49,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `ProgressCallbacks` now has a `verifying` method to notify when post-flash checksum checking has begun (#908)
 - Implement `From<Connection> for Port` and both `From<Flasher> for Connection` and `Port` conversions (#915)
 - Add support for serial port configuration files. (#777)
-- Add support for secure padding for save-image (#876)
 
 ### Changed
 

cargo-espflash/src/main.rs

@@ -373,6 +373,7 @@ fn flash(args: FlashArgs, config: &Config) -> Result<()> {
             config,
             chip,
             target_xtal_freq,
+            args.idf_format_args.secure_pad_v2,
         );
         let image_format = make_image_format(
             &elf_data,
@@ -643,6 +644,7 @@ fn save_image(args: SaveImageArgs, config: &Config) -> Result<()> {
         config,
         args.save_image_args.chip,
         xtal_freq,
+        args.idf_format_args.secure_pad_v2,
     );
     let image_format = make_image_format(
         &elf_data,

espflash/src/bin/espflash.rs

@@ -286,6 +286,7 @@ fn flash(args: FlashArgs, config: &Config) -> Result<()> {
             config,
             chip,
             target_xtal_freq,
+            args.idf_format_args.secure_pad_v2,
         );
         let image_format = make_image_format(
             &elf_data,
@@ -370,6 +371,7 @@ fn save_image(args: SaveImageArgs, config: &Config) -> Result<()> {
         config,
         args.save_image_args.chip,
         xtal_freq,
+        args.idf_format_args.secure_pad_v2,
     );
     let image_format = make_image_format(
         &elf_data,

espflash/src/connection/reset.rs

@@ -30,20 +30,25 @@ const EXTRA_RESET_DELAY: u64 = 500; // ms
 
 /// Reset strategies for resetting a target device.
 pub trait ResetStrategy {
+    /// Resets the target device.
     fn reset(&self, serial_port: &mut Port) -> Result<(), Error>;
 
+    /// Sets DTR (data terminal ready) to a specified level.
     fn set_dtr(&self, serial_port: &mut Port, level: bool) -> Result<(), Error> {
         serial_port.write_data_terminal_ready(level)?;
 
         Ok(())
     }
 
+    /// Sets RTS (request to send) to a specified level.
     fn set_rts(&self, serial_port: &mut Port, level: bool) -> Result<(), Error> {
         serial_port.write_request_to_send(level)?;
 
         Ok(())
     }
 
+    /// Sets RTS (request to send) and DTS (data termina lready) to specified
+    /// levels.
     #[cfg(unix)]
     fn set_dtr_rts(
         &self,