Skip to content

GDMA vs DMA interrupt bit discrepancies #2193

@Dominaezzz

Description

@Dominaezzz

Whilst drafting a PR to enumset-ify the DMA interrupts I noticed some discrepancies in the interrupts of the RegisterAccess implementations.

is_in_done() different between GDMA and PDMA

GDMA says it's IN_SUC_EOF.
I2S PDMA and SPI PDMA say it's IN_DONE. (This is probably the wrong one)

is_out_done() different between GDMA and PDMA

SPI PDMA and GDMA says it's OUT_TOTAL_EOF.
I2S PDMA says it's OUT_EOF. (This is probably the wrong one)

out_eof inconsistency (in both GDMA and PDMA)

listen_out_eof()/unlisten_out_eof()/is_listening_out_eof says it's OUT_TOTAL_EOF.
is_out_eof_interrupt_set()/reset_out_eof_interrupt() says it's OUT_EOF.
Hard to say which is wrong here at a glance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions