build: remove eslint 8 build

BREAKING CHANGE: eslint 8 support removed

Author: RebeccaStevens

package.json

@@ -34,25 +34,13 @@
     "Jonas Kello"
   ],
   "exports": {
-    ".": {
-      "types": {
-        "import": "./lib/classic.d.mts",
-        "require": "./lib/classic.d.cts"
-      },
-      "import": "./lib/classic.mjs",
-      "require": "./lib/classic.cjs"
+    "types": {
+      "require": "./lib/index.d.cts",
+      "import": "./lib/index.d.mts"
     },
-    "./flat": {
-      "types": {
-        "import": "./lib/flat.d.mts",
-        "require": "./lib/flat.d.cts"
-      },
-      "import": "./lib/flat.mjs",
-      "require": "./lib/flat.cjs"
-    }
+    "require": "./lib/index.cjs",
+    "import": "./lib/index.mjs"
   },
-  "main": "lib/classic.cjs",
-  "types": "lib/classic.d.cts",
   "files": [
     "lib/",
     "package.json",

rollup.config.ts

@@ -1,5 +1,5 @@
 import { rollupPlugin as rollupPluginDeassert } from "deassert";
-import { type RollupOptions } from "rollup";
+import { type OutputOptions, type RollupOptions } from "rollup";
 import rollupPluginAutoExternal from "rollup-plugin-auto-external";
 import rollupPluginTs from "rollup-plugin-ts";
 
@@ -12,16 +12,15 @@ const treeshake = {
   unknownGlobalSideEffects: false,
 } satisfies RollupOptions["treeshake"];
 
-const classicCJS = {
-  input: "src/classic.ts",
-
-  output: {
-    file: pkg.exports["."].require,
-    format: "cjs",
-    sourcemap: false,
+const output = {
+  sourcemap: false,
+  generatedCode: {
+    preset: "es2015",
   },
+} satisfies Omit<OutputOptions, "file">;
 
-  plugins: [
+function getPlugins(format: "esm" | "cjs"): RollupOptions["plugins"] {
+  return [
     rollupPluginAutoExternal(),
     rollupPluginTs({
       transpileOnly: true,
@@ -32,7 +31,7 @@ const classicCJS = {
           paths: {
             ...resolvedConfig.paths,
             "#eslint-plugin-functional/conditional-imports/*": [
-              "src/utils/conditional-imports/cjs/*",
+              `src/utils/conditional-imports/${format}/*`,
             ],
           },
         }),
@@ -41,111 +40,35 @@ const classicCJS = {
     rollupPluginDeassert({
       include: ["**/*.{js,ts}"],
     }),
-  ],
+  ];
+}
 
-  treeshake,
-} satisfies RollupOptions;
-
-const classicESM = {
-  input: "src/classic.ts",
+const esm = {
+  input: "src/index.ts",
 
   output: {
-    file: pkg.exports["."].import,
+    ...output,
+    file: pkg.exports.import,
     format: "esm",
-    sourcemap: false,
   },
 
-  plugins: [
-    rollupPluginAutoExternal(),
-    rollupPluginTs({
-      transpileOnly: true,
-      tsconfig: {
-        fileName: "tsconfig.build.json",
-        hook: (resolvedConfig) => ({
-          ...resolvedConfig,
-          paths: {
-            ...resolvedConfig.paths,
-            "#eslint-plugin-functional/conditional-imports/*": [
-              "src/utils/conditional-imports/esm/*",
-            ],
-          },
-        }),
-      },
-    }),
-    rollupPluginDeassert({
-      include: ["**/*.{js,ts}"],
-    }),
-  ],
+  plugins: getPlugins("esm"),
 
   treeshake,
 } satisfies RollupOptions;
 
-const flatCJS = {
-  input: "src/flat.ts",
+const cjs = {
+  input: "src/index.ts",
 
   output: {
-    file: pkg.exports["./flat"].require,
+    ...output,
+    file: pkg.exports.require,
     format: "cjs",
-    sourcemap: false,
   },
 
-  plugins: [
-    rollupPluginAutoExternal(),
-    rollupPluginTs({
-      transpileOnly: true,
-      tsconfig: {
-        fileName: "tsconfig.build.json",
-        hook: (resolvedConfig) => ({
-          ...resolvedConfig,
-          paths: {
-            ...resolvedConfig.paths,
-            "#eslint-plugin-functional/conditional-imports/*": [
-              "src/utils/conditional-imports/cjs/*",
-            ],
-          },
-        }),
-      },
-    }),
-    rollupPluginDeassert({
-      include: ["**/*.{js,ts}"],
-    }),
-  ],
-
-  treeshake,
-} satisfies RollupOptions;
-
-const flatESM = {
-  input: "src/flat.ts",
-
-  output: {
-    file: pkg.exports["./flat"].import,
-    format: "esm",
-    sourcemap: false,
-  },
-
-  plugins: [
-    rollupPluginAutoExternal(),
-    rollupPluginTs({
-      transpileOnly: true,
-      tsconfig: {
-        fileName: "tsconfig.build.json",
-        hook: (resolvedConfig) => ({
-          ...resolvedConfig,
-          paths: {
-            ...resolvedConfig.paths,
-            "#eslint-plugin-functional/conditional-imports/*": [
-              "src/utils/conditional-imports/esm/*",
-            ],
-          },
-        }),
-      },
-    }),
-    rollupPluginDeassert({
-      include: ["**/*.{js,ts}"],
-    }),
-  ],
+  plugins: getPlugins("cjs"),
 
   treeshake,
 } satisfies RollupOptions;
 
-export default [classicCJS, classicESM, flatCJS, flatESM];
+export default [cjs, esm];

src/classic.ts

@@ -6,49 +6,21 @@ import { readdirSync } from "node:fs";
 
 import { describe, expect, it } from "vitest";
 
-import classic from "#eslint-plugin-functional/classic";
-import flat from "#eslint-plugin-functional/flat";
+import functional from "#eslint-plugin-functional";
 
-describe("Flat", () => {
+describe("index", () => {
   it("should have all the rules", () => {
     const ruleFiles: string[] = readdirSync("./src/rules").filter(
       (file) => file !== "index.ts" && file.endsWith(".ts"),
     );
 
     expect(
-      Object.hasOwn(flat, "rules"),
+      Object.hasOwn(functional, "rules"),
       'The plugin\'s config object should have a "rules" property.',
     );
-    expect(ruleFiles.length).to.equal(Object.keys(flat.rules ?? {}).length);
-  });
-
-  it("should have all the configs", () => {
-    const configFiles: string[] = readdirSync("./src/configs").filter(
-      (file) => file !== "index.ts" && file.endsWith(".ts"),
-    );
-
-    expect(
-      Object.hasOwn(flat, "configs"),
-      'The plugin\'s config object should have a "configs" property.',
-    );
-    expect(configFiles.length).to.equal(
-      Object.keys(flat.configs ?? {}).length,
-      "should have all the configs except deprecated",
-    );
-  });
-});
-
-describe("Classic", () => {
-  it("should have all the rules", () => {
-    const ruleFiles: string[] = readdirSync("./src/rules").filter(
-      (file) => file !== "index.ts" && file.endsWith(".ts"),
-    );
-
-    expect(
-      Object.hasOwn(classic, "rules"),
-      'The plugin\'s config object should have a "rules" property.',
+    expect(ruleFiles.length).to.equal(
+      Object.keys(functional.rules ?? {}).length,
     );
-    expect(ruleFiles.length).to.equal(Object.keys(classic.rules ?? {}).length);
   });
 
   it("should have all the configs", () => {
@@ -57,11 +29,11 @@ describe("Classic", () => {
     );
 
     expect(
-      Object.hasOwn(classic, "configs"),
+      Object.hasOwn(functional, "configs"),
       'The plugin\'s config object should have a "configs" property.',
     );
     expect(configFiles.length).to.equal(
-      Object.keys(classic.configs ?? {}).length,
+      Object.keys(functional.configs ?? {}).length,
       "should have all the configs except deprecated",
     );
   });

src/flat.ts renamed to src/index.ts

@@ -31,8 +31,7 @@
     "types": ["vitest/importMeta"],
     "baseUrl": ".",
     "paths": {
-      "#eslint-plugin-functional/flat": ["src/flat.ts"],
-      "#eslint-plugin-functional/classic": ["src/classic.ts"],
+      "#eslint-plugin-functional": ["src/index.ts"],
       "#eslint-plugin-functional/configs/*": ["src/configs/*"],
       "#eslint-plugin-functional/options": ["src/options"],
       "#eslint-plugin-functional/rules": ["src/rules"],