cleanup linting

Author: RebeccaStevens

src/configs/disable-type-checked.ts

@@ -5,6 +5,6 @@ import { ruleNameScope } from "#eslint-plugin-functional/utils/misc";
 
 export default Object.fromEntries(
   Object.entries(rules)
-    .filter(([, rule]) => rule.meta.docs?.requiresTypeChecking === true)
+    .filter(([, rule]) => rule.meta.docs.requiresTypeChecking === true)
     .map(([name]) => [`${ruleNameScope}/${name}`, "off"]),
 ) satisfies FlatConfig.Config["rules"];

src/rules/no-classes.ts

@@ -4,9 +4,9 @@ import { type RuleContext } from "@typescript-eslint/utils/ts-eslint";
 import { ruleNameScope } from "#eslint-plugin-functional/utils/misc";
 import { type ESClass } from "#eslint-plugin-functional/utils/node-types";
 import {
+  createRule,
   type NamedCreateRuleCustomMeta,
   type RuleResult,
-  createRule,
 } from "#eslint-plugin-functional/utils/rule";
 
 /**

src/rules/no-loop-statements.ts

@@ -4,9 +4,9 @@ import { type RuleContext } from "@typescript-eslint/utils/ts-eslint";
 import { ruleNameScope } from "#eslint-plugin-functional/utils/misc";
 import { type ESLoop } from "#eslint-plugin-functional/utils/node-types";
 import {
+  createRule,
   type NamedCreateRuleCustomMeta,
   type RuleResult,
-  createRule,
 } from "#eslint-plugin-functional/utils/rule";
 
 /**

src/rules/no-promise-reject.ts

@@ -4,9 +4,9 @@ import { type RuleContext } from "@typescript-eslint/utils/ts-eslint";
 
 import { ruleNameScope } from "#eslint-plugin-functional/utils/misc";
 import {
+  createRule,
   type NamedCreateRuleCustomMeta,
   type RuleResult,
-  createRule,
 } from "#eslint-plugin-functional/utils/rule";
 import {
   isIdentifier,

src/rules/no-this-expressions.ts

@@ -4,9 +4,9 @@ import { type RuleContext } from "@typescript-eslint/utils/ts-eslint";
 
 import { ruleNameScope } from "#eslint-plugin-functional/utils/misc";
 import {
+  createRule,
   type NamedCreateRuleCustomMeta,
   type RuleResult,
-  createRule,
 } from "#eslint-plugin-functional/utils/rule";
 
 /**

src/settings/immutability.ts

@@ -1,9 +1,9 @@
 import { type SharedConfigurationSettings } from "@typescript-eslint/utils";
 import {
   Immutability,
+  getDefaultOverrides as getDefaultImmutabilityOverrides,
   type ImmutabilityOverrides,
   type TypeSpecifier,
-  getDefaultOverrides as getDefaultImmutabilityOverrides,
 } from "is-immutable-type";
 
 declare module "@typescript-eslint/utils" {
@@ -13,8 +13,8 @@ declare module "@typescript-eslint/utils" {
     from?: Immutability | keyof typeof Immutability;
   };
 
-  // eslint-disable-next-line ts/no-shadow
-  type SharedConfigurationSettings = {
+  // eslint-disable-next-line ts/consistent-type-definitions, ts/no-shadow
+  interface SharedConfigurationSettings {
     immutability?: {
       overrides?:
         | OverridesSetting[]
@@ -23,7 +23,7 @@ declare module "@typescript-eslint/utils" {
             values?: OverridesSetting[];
           };
     };
-  };
+  }
 }
 
 /**

src/utils/rule.ts

@@ -1,8 +1,8 @@
 import { type TSESTree } from "@typescript-eslint/utils";
 import {
-  type NamedCreateRuleMeta,
   RuleCreator,
   getParserServices,
+  type NamedCreateRuleMeta,
 } from "@typescript-eslint/utils/eslint-utils";
 import {
   type ReportDescriptor,
@@ -11,8 +11,8 @@ import {
 } from "@typescript-eslint/utils/ts-eslint";
 import {
   Immutability,
-  type ImmutabilityOverrides,
   getTypeImmutability,
+  type ImmutabilityOverrides,
 } from "is-immutable-type";
 import { type Node as TSNode, type Type, type TypeNode } from "typescript";
 
@@ -50,6 +50,9 @@ export type NamedCreateRuleCustomMeta<
  */
 export type BaseOptions = ReadonlyArray<unknown>;
 
+/**
+ * The definition of a rule.
+ */
 export type RuleDefinition<
   MessageIds extends string,
   Options extends BaseOptions,

tests/configs.test.ts

@@ -15,10 +15,10 @@ import { rules } from "#eslint-plugin-functional/rules";
 
 describe("configs", () => {
   const allRules = Object.values(rules);
-  const allConfigRules = Object.keys(all ?? {});
-  const offConfigRules = Object.entries(off ?? {});
+  const allConfigRules = Object.keys(all);
+  const offConfigRules = Object.entries(off);
   const allNonDeprecatedRules = allRules.filter(
-    (rule) => rule.meta === undefined || rule.meta.deprecated !== true,
+    (rule) => rule.meta.deprecated !== true,
   );
 
   it('"All" - should have the right number of rules', () => {
@@ -71,10 +71,10 @@ describe("configs", () => {
   describe.each(configs)(
     '"%s" Config rules are in the "All" Config',
     (name, config) => {
-      const ruleNames = Object.keys(config ?? {});
+      const ruleNames = Object.keys(config);
 
       it.each(ruleNames)(`%s`, (rule) => {
-        expect(all?.[rule]).toBeDefined();
+        expect(all[rule]).toBeDefined();
       });
     },
   );