Skip to content

Commit e903bb9

Browse files
committed
add TODO notes about improving checkouts related errors
1 parent b7b33fb commit e903bb9

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/rebar_prv_lock.erl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ do(State) ->
4040

4141
OldLockNames = [element(1,L) || L <- OldLocks],
4242
NewLockNames = [element(1,L) || L <- Locks],
43+
44+
%% TODO: don't output this message if the dep is now a checkout
4345
rebar_utils:info_useless(OldLockNames, NewLockNames),
4446

4547
{ok, State1};

src/rebar_prv_upgrade.erl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ prepare_locks([Name|Names], Deps, Locks, Unlocks, Dict, AltDeps) ->
217217
false ->
218218
case rebar_utils:tup_find(AtomName, AltDeps) of
219219
false ->
220+
%% TODO: output a different error if the app is a checkout
220221
?PRV_ERROR({unknown_dependency, Name});
221222
_ -> % non-default profile dependency found, pass through
222223
prepare_locks(Names, Deps, Locks, Unlocks, Dict, AltDeps)

0 commit comments

Comments
 (0)