preparing 2.0.2 release

Author: ericsizemore

CHANGELOG.md

@@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.0.2] - 2024-12-03
+
+### Changed
+
+  * Updated total coverage calculation within the CoverageCheck::processByFile() method, as it was producing different totals than the normal process method.
+    * Now relies on total elements and total covered elements, instead of gathering percent coverage for each file and dividing by file count.  
+    * Updated unit test(s) accordingly
+
+
 ## [2.0.1] - 2024-10-09
 
 ### Added
@@ -123,6 +132,7 @@ This initial version is forked from [rregeer/phpunit-coverage-check](https://git
 
 
 [unreleased]: https://github.com/ericsizemore/phpunit-coverage-check/tree/master
+[2.0.2]: https://github.com/ericsizemore/phpunit-coverage-check/releases/tag/2.0.2
 [2.0.1]: https://github.com/ericsizemore/phpunit-coverage-check/releases/tag/2.0.1
 [2.0.0]: https://github.com/ericsizemore/phpunit-coverage-check/releases/tag/2.0.0
 [1.0.0]: https://github.com/ericsizemore/phpunit-coverage-check/releases/tag/1.0.0

src/CoverageCheck.php

@@ -130,6 +130,7 @@ public function process(): false|float
         if ($rawMetrics === false) {
             return false;
         }
+
         //@codeCoverageIgnoreEnd
 
         /**
@@ -169,8 +170,9 @@ public function process(): false|float
      */
     public function processByFile(): array|false
     {
-        $fileMetrics   = [];
-        $totalCoverage = 0;
+        $fileMetrics          = [];
+        $totalElementsCovered = 0;
+        $totalElements        = 0;
 
         $rawMetrics = $this->loadMetrics(self::XPATH_FILES) ?? false;
 
@@ -197,7 +199,8 @@ public function processByFile(): array|false
             }
 
             $coveragePercentage = $coveredMetrics / $totalMetrics * 100;
-            $totalCoverage += $coveragePercentage;
+            $totalElementsCovered += $coveredMetrics;
+            $totalElements        += $totalMetrics;
 
             $fileMetrics[(string) $file['name']] = [
                 'coveredMetrics' => $coveredMetrics,
@@ -208,15 +211,11 @@ public function processByFile(): array|false
 
         unset($rawMetrics);
 
-        $fileCount = \count($fileMetrics);
-
-        if ($fileCount === 0) {
+        if ($totalElements === 0) {
             return false;
         }
 
-        if ($totalCoverage !== 0) {
-            $totalCoverage /= $fileCount;
-        }
+        $totalCoverage = $totalElementsCovered / $totalElements * 100;
 
         return [
             'fileMetrics'   => $fileMetrics,

tests/src/Command/CoverageCheckCommandTest.php

@@ -301,12 +301,12 @@ public function testShowFilesTableOutputBelowThreshold(): void
     {
         $this->tester->run([
             'cloverfile'   => self::$fixtures['valid'],
-            'threshold'    => 90,
+            'threshold'    => 91,
             '--show-files' => true,
         ]);
 
         self::assertSame(self::$fixtures['valid'], $this->tester->getInput()->getArgument('cloverfile'));
-        self::assertSame(90, $this->tester->getInput()->getArgument('threshold'));
+        self::assertSame(91, $this->tester->getInput()->getArgument('threshold'));
 
         $eol = PHP_EOL;
 
@@ -316,7 +316,7 @@ public function testShowFilesTableOutputBelowThreshold(): void
         $expected .= '  /tmp/Example/String.php       36/38                      94.74%    ' . $eol;
         $expected .= '  /tmp/Example/StringList.php   20/24                      83.33%    ' . $eol;
         $expected .= ' ----------------------------- -------------------------- ---------- ' . $eol;
-        $expected .= '  Overall Totals                56/62                      89.04%    ' . $eol;
+        $expected .= '  Overall Totals                56/62                      90.32%    ' . $eol;
         $expected .= ' ----------------------------- -------------------------- ----------';
 
         self::assertEquals($expected, trim($this->tester->getDisplay()));