From e8546f507badc49aea4eb3e529dd3323b652ce04 Mon Sep 17 00:00:00 2001 From: ScriptSmith Date: Mon, 5 Aug 2024 09:50:54 +1000 Subject: [PATCH] Use 1 core to 8GB ram ratio --- src/components/tool/guide/Config.js | 10 ++++++++-- src/components/tool/guide/EresearchJob/EresearchJob.js | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/components/tool/guide/Config.js b/src/components/tool/guide/Config.js index 36f9e6d1..7b938907 100644 --- a/src/components/tool/guide/Config.js +++ b/src/components/tool/guide/Config.js @@ -6,7 +6,7 @@ import ConfigSlider from "./Config/ConfigSlider"; export const DEFAULT_CONFIG = { nodes: 1, cpuCores: 4, - ram: 16, + ram: 32, gpuModules: 1, wallTime: { hour: 1, minute: 0 }, isArrayJob: "Standalone", @@ -134,7 +134,10 @@ export const getCpuCores = (config, onChange) => () => { min: 1, max: cpuCores, step: 1, - onChange: onChange("cpuCores"), + onChange: (value) => { + onChange("cpuCores")(value); + onChange("ram")(value * 8); + }, }} /> ), @@ -177,6 +180,9 @@ export const getRam = (config, onChange) => () => { step: 8, onChange: onChange("ram"), }} + showAlert={config?.ram !== config?.cpuCores * 8} + alertType={"warning"} + alertMsg={"The recommended RAM is 8GB per core."} /> ), show: (config) => isLyra(config), diff --git a/src/components/tool/guide/EresearchJob/EresearchJob.js b/src/components/tool/guide/EresearchJob/EresearchJob.js index af4f070d..ae3fe31e 100644 --- a/src/components/tool/guide/EresearchJob/EresearchJob.js +++ b/src/components/tool/guide/EresearchJob/EresearchJob.js @@ -27,7 +27,7 @@ import { EresearchInstructions } from "./EresearchInstructions"; const getConfigGroups = (config, onConfigChange = () => {}) => { const onChange = (key) => (value) => - onConfigChange({ ...config, [key]: value }); + onConfigChange((prev) => ({ ...prev, [key]: value })); return { service: () => {