Non numerical values in ODS file

[bglass88]

I keep getting errors running rp2_us saying that various values are non-numerical (presumably str type based on the error). For example:

  INFO: Country: us
  INFO: Generation Language: en
  INFO: Accounting method: hifo
  INFO: Configuration file: rp2_config_2024_debug.ini
  INFO: Input file: rp2_input_2024_debug5.ods
  INFO: Processing ADA
  INFO: Processing ALGO
  ERROR: Fatal exception occurred:
  Traceback (most recent call last):
    File "/usr/local/lib/python3.11/dist-packages/rp2/ods_parser.py", line 258, in _process_constructor_argument_pack
      argument_pack[numeric_parameter] = RP2Decimal(f"{value:.11f}") if value is not None else None
                                                    ^^^^^^^^^^^^^^^
  ValueError: Unknown format code 'f' for object of type 'str'
  
  The above exception was the direct cause of the following exception:
  
  Traceback (most recent call last):
    File "/usr/local/lib/python3.11/dist-packages/rp2/rp2_main.py", line 151, in _rp2_main_internal
      input_data: InputData = parse_ods(configuration=configuration, asset=asset, input_file_handle=input_file_handle)
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/local/lib/python3.11/dist-packages/rp2/ods_parser.py", line 125, in parse_ods
      _create_and_process_transaction(configuration, row_values, current_table_type, i + 1, unfiltered_transaction_sets, artificial_transaction_list)
    File "/usr/local/lib/python3.11/dist-packages/rp2/ods_parser.py", line 161, in _create_and_process_transaction
      transaction: AbstractTransaction = _create_transaction(configuration, current_table_type, internal_id, row_values)
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/local/lib/python3.11/dist-packages/rp2/ods_parser.py", line 276, in _create_transaction
      argument_pack = _process_constructor_argument_pack(configuration, argument_pack, internal_id, "InTransaction")
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/local/lib/python3.11/dist-packages/rp2/ods_parser.py", line 260, in _process_constructor_argument_pack
      raise RP2ValueError(f"Argument '{numeric_parameter}' has non-numeric value: {value}") from exc
  rp2.rp2_error.RP2ValueError: Argument 'fiat_fee' has non-numeric value: 0.0

I have tried changed the cell types and re-entering the values manually in M365 online an Google Sheets and I keep coming back with the same error.

I get these errors while trying to big my first issue "Total in-transaction crypto value < total taxable crypto value" issues as reported in other discussions. I have manually added all the in IN transactions (buys and staking) and they are 0.7 greater than the single OUT (sell) transaction, so no idea what's going.

It's been about 25 hours of formatting input tables and trying to troubleshoot these issues, so this is my last shot before giving up and paying an exorbitant amount for a crypto tax aggregation service.

Perhaps the program would be less prone to these types of formatting or other errors if it was written to read in a single CSV transaction file without arbitrary tables and sheets for IN/OUT/INTRA and asset types. INTRA exchange/wallet transfers can easily be handled by matching Send and Receive transactions with the same ID.

[eprbell]

Can you attach a small .ods file and config reproducing the issue?

[eprbell]

Regarding your other comment about different input format: that can be addressed by writing an input plugin for DaLI, RP2's data loader project.

[bglass88]

Hi eprbell,

Thanks for the help. I have attached the files here. The config file was changed to a TXT because INI are not allowed.

rp2_input_2024_debug6.ods

rp2_config_2024_debug6.txt

[eprbell]

The issue was caused by some weird data formatting in the ods file. If you format the bad cells as Number and then remove the extra apostrophe RP2 works correctly. I'm attaching the cleaned up ods file.

issue142.ods

[eprbell]

Closing the issue.

[bglass88]

Hi eprbell,

Thank you for helping with the formatting issue. However, the balances still aren't adding up and it's reporting the "Total in-transaction crypto value < total taxable crypto value" error for ALGO. Total in up until the single sell should add to 781.474852 vs. the sell amount 781.40. Rounding issue?

  INFO: Country: us
  INFO: Generation Language: en
  INFO: Accounting method: hifo
  INFO: Configuration file: rp2_config_2024_debug6.ini
  INFO: Input file: issue142.ods
  INFO: Processing ALGO
  ERROR: Fatal exception occurred:
  Traceback (most recent call last):
    File "/usr/local/lib/python3.11/dist-packages/rp2/rp2_main.py", line 154, in _rp2_main_internal
      computed_data: ComputedData = compute_tax(configuration=configuration, accounting_engine=accounting_engine, input_data=input_data)
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/local/lib/python3.11/dist-packages/rp2/tax_engine.py", line 44, in compute_tax
      unfiltered_gain_loss_set: GainLossSet = _create_unfiltered_gain_and_loss_set(configuration, accounting_engine, input_data, unfiltered_taxable_event_set)
                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/local/lib/python3.11/dist-packages/rp2/tax_engine.py", line 197, in _create_unfiltered_gain_and_loss_set
      raise RP2ValueError("Total in-transaction crypto value < total taxable crypto value") from None
  rp2.rp2_error.RP2ValueError: Total in-transaction crypto value < total taxable crypto value

[eprbell]

It works well for me:

INFO: Country: us
INFO: Generation Language: en
INFO: Accounting method: fifo
INFO: Configuration file: issue142.ini
INFO: Input file: issue142.ods
INFO: Processing ALGO
INFO: Processing AVAX
INFO: Generating output for plugin 'rp2.plugin.report.open_positions'
INFO: Plugin 'rp2.plugin.report.open_positions' output: [snip]/tmp/output/issue_142_fifo_open_positions.ods
INFO: Generating output for plugin 'rp2.plugin.report.rp2_full_report'
INFO: Plugin 'rp2.plugin.report.rp2_full_report' output: [snip]/tmp/output/issue_142_fifo_rp2_full_report.ods
INFO: Generating output for plugin 'rp2.plugin.report.us.tax_report_us'
INFO: Plugin 'rp2.plugin.report.us.tax_report_us' output: [snip]/tmp/output/issue_142_fifo_tax_report_us.ods
INFO: Log file: ./log/rp2_2025_03_23_20_54_40_258953.log
INFO: Generated output directory: output
INFO: Done

Are you using the latest version of RP2?

[bglass88]

My config is running HIFO. Can you see if hifo works for you?

[eprbell]

Ah, yes, if I use HIFO I get the same problem. Unfortunately I don't have the time to debug using your file (it's a bit too large and it would take longer than I have). I can suggest two possible paths forward:

• try to reproduce with a smaller file, so I can take a look at it.
• run with debug log activated and inspect the log: prepend the command line with LOG_LEVEL=DEBUG, e.g.:
  LOG_LEVEL=DEBUG rp2_us -o output -p crypto_example_ config/crypto_example.ini input/crypto_example.ods
  the logs contain a full description of what the tax engine is trying to do and can be found in the log directory.

I suggest a binary search approach (i.e. remove the last half of the lines and see if you can repro, etc.).

[eprbell]

Reopening this.

[jayr0d]

There's certainly an issue with the HIFO algorithm. It was introduced in 1.6.0.

When I did taxes last year I used roughly equivalent to 1.5.1 and HIFO. My same 2023 data generates fine this year for both LIFO and HIFO under 1.5.1, but only LIFO generates under 1.7.2 (or 1.6.0). I am currently using 1.5.1 to generate HIFO and am using my tweaks under #110 to find some rounding issues and exactly where things go negative so I can tweak the DaLI CSV data (I do everything via manual import). There's just too much output in the normal RP2 DEBUG for me to make sense of.

If you have LIFO generating under 1.7.2 I suggest you try generating LIFO and HIFO under 1.5.1. You can compare the two LIFO outputs to see if there are any significant differences in calculations (as far as I remember I did not see any in my case).

One of my tokens has a pretty trivial data set and it is getting caught in this, but I need to get my taxes filed before I can look into it further.

[jayr0d]

Looking into this a little bit. It has something to do with Buy and Staking. In my test transaction set I have a Buy followed by a bunch of Staking and a single Sell. If I change all Staking to Buy, it works. If I change the Buy to Staking, it does not.

Gift and Donate also work, so it seems to be an issue with earn transaction types.

[jayr0d]

Attached is smaller data set that still has the problem.

ALGO_crypto_data.ods

It is consistently missing rows 4-5 when processing DEBUG: tax_engine: taxable > acquired