-
Notifications
You must be signed in to change notification settings - Fork 51
Description
Just want to offer a small suggestion for something that could benefit from clarification in the docs:
The input_files page refers to fields like the following that contain no_fee
or with_fee
in their names and refer to "excluding fees" and "including fees" in their descriptions.
crypto_out_no_fee: how much of the given cryptocurrency was sold or sent with the transaction (excluding fees).
crypto_out_with_fee (optional): how much of the given cryptocurrency was sold or sent with the transaction (including fees). If not provided, RP2 will compute this value automatically.
fiat_out_no_fee (optional): fiat value of the transaction without fees. If not provided, RP2 will compute this value automatically.
I don't often have to deal with fees in RP2, as I mostly use Solana, and fees are so low I don't even record them. But when I do need to deal with larger fees, it can be confusing.
Does no_fee
/ "excluding fee" mean that the fee has already been subtracted from the amount (i.e. what remains is net of fees)? Or does it mean "excluding the impact of the fee"? (In order words, in the latter case, the fee has not yet been subtracted and it is the gross amount?) And similarly for with_fee
/ "including fee".
Hopefully that distinction / point of confusion makes sense?
I'm happy to do a PR for this change if you'll help me understand the meaning of these fields. Could you give a simple example to make it clear?
Thanks.