Apply CMake fixes for debian packaging.

Thanks @thekhalifa

Author: Jojo-1000

CMakeLists.txt

@@ -1,10 +1,4 @@
-cmake_minimum_required(VERSION 3.10.2)
-
-if(${CMAKE_VERSION} VERSION_LESS 3.11)
-	cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
-else()
-	cmake_policy(VERSION 3.11)
-endif()
+cmake_minimum_required(VERSION 3.10.2...3.28)
 
 # Add cmake dir to module path, so Find*.cmake can be found
 set(CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake" ${CMAKE_MODULE_PATH})
@@ -27,11 +21,12 @@ option(hueplusplus_NO_EXTERNAL_LIBRARIES "Do not try to use external libraries"
 
 # Try to find installed packages
 if(NOT hueplusplus_NO_EXTERNAL_LIBRARIES)
-	find_package(MbedTLS)
-	find_package(nlohmann_json)
+    # Suppress warnings if libraries are not found, they will be built from submodules
+	find_package(MbedTLS QUIET)
+	find_package(nlohmann_json QUIET)
 endif()
 
-set(NEED_SUBMODULES NOT (${mbedtls_FOUND} AND ${nlohmann_json_FOUND}))
+set(NEED_SUBMODULES NOT (${MbedTLS_FOUND} AND ${nlohmann_json_FOUND}))
 
 option(CLANG_TIDY_FIX "Perform fixes for Clang-Tidy" OFF)
 find_program(CLANG_TIDY_EXE NAMES "clang-tidy" DOC "Path to clang-tidy executable")
@@ -92,8 +87,9 @@ if (1 AND APPLE)
 	set(CMAKE_MACOSX_RPATH 1)
 endif()
 
-if(NOT mbedtls_FOUND)
+if(NOT MbedTLS_FOUND)
 	# Build mbedtls if not installed
+	message(STATUS "MbedTLS was not found, the submodule is used.")
 	set(USE_STATIC_MBEDTLS_LIBRARY ON)
 	set(USE_SHARED_MBEDTLS_LIBRARY OFF)
 	add_subdirectory("lib/mbedtls" EXCLUDE_FROM_ALL)
@@ -112,6 +108,7 @@ endif()
 
 if(NOT nlohmann_json_FOUND)
 	# Use embedded json
+	message(STATUS "nlohmann_json was not found, the submodule is used.")
 	# disable tests for json
 	set(JSON_BuildTests OFF CACHE INTERNAL "")
 	add_subdirectory("lib/json" EXCLUDE_FROM_ALL)

src/CMakeLists.txt

@@ -57,22 +57,33 @@ foreach(src ${hueplusplus_SOURCES})
 endforeach()
 set(hueplusplus_SOURCES ${_srcList} PARENT_SCOPE)
 
+# For install dir variables
+include(GNUInstallDirs)
+
 # hueplusplus shared library
 add_library(hueplusplusshared SHARED ${hueplusplus_SOURCES})
 target_link_libraries(hueplusplusshared PRIVATE MbedTLS::mbedtls)
 target_link_libraries(hueplusplusshared PUBLIC nlohmann_json::nlohmann_json)
 target_compile_features(hueplusplusshared PUBLIC cxx_std_14)
 target_include_directories(hueplusplusshared PUBLIC $<BUILD_INTERFACE:${hueplusplus_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include>)
-install(TARGETS hueplusplusshared DESTINATION lib)
+
 
 # hueplusplus static library
 add_library(hueplusplusstatic STATIC ${hueplusplus_SOURCES})
 target_link_libraries(hueplusplusstatic PRIVATE MbedTLS::mbedtls)
 target_link_libraries(hueplusplusstatic PUBLIC nlohmann_json::nlohmann_json)
 target_compile_features(hueplusplusstatic PUBLIC cxx_std_14)
-install(TARGETS hueplusplusstatic DESTINATION lib)
+if(NOT WIN32)
+    # On windows, a shared library will also generate a .lib import library, making different names necessary.
+    # On other platforms the file endings are different, so the names can be the same.
+    set_target_properties(hueplusplusshared PROPERTIES OUTPUT_NAME hueplusplus SOVERSION 1)
+    set_target_properties(hueplusplusstatic PROPERTIES OUTPUT_NAME hueplusplus)
+endif()
+
+install(TARGETS hueplusplusshared DESTINATION ${CMAKE_INSTALL_LIBDIR})
+install(TARGETS hueplusplusstatic DESTINATION ${CMAKE_INSTALL_LIBDIR})
 target_include_directories(hueplusplusstatic PUBLIC $<BUILD_INTERFACE:${hueplusplus_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include>)
-install(DIRECTORY "${PROJECT_SOURCE_DIR}/include/" DESTINATION include)
+install(DIRECTORY "${PROJECT_SOURCE_DIR}/include/" DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
 
 # Export the package for use from the build-tree
 # (this registers the build-tree with a global CMake-registry)