Fix split to columns by newline (#12915)

* Add test and fix

* API

Author: AdRiley

distribution/lib/Standard/Database/0.0.0-dev/docs/api/DB_Table.md

@@ -78,7 +78,7 @@
     - set self value:(Standard.Database.DB_Column.DB_Column|Standard.Base.Data.Text.Text|Standard.Table.Expression.Expression|Standard.Base.Data.Array.Array|Standard.Base.Data.Vector.Vector|Standard.Base.Data.Range.Range|Standard.Base.Data.Time.Date_Range.Date_Range|Standard.Table.Internal.Constant_Column.Constant_Column|Standard.Table.Simple_Expression.Simple_Expression) as:Standard.Base.Data.Text.Text= set_mode:Standard.Table.Set_Mode.Set_Mode= on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior= -> Standard.Base.Any.Any
     - sort self columns:(Standard.Base.Any.Any|Standard.Table.Sort_Column.Sort_Column)= text_ordering:Standard.Base.Data.Text.Text_Ordering.Text_Ordering= error_on_missing_columns:Standard.Base.Data.Boolean.Boolean= on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior= -> Standard.Base.Any.Any
     - sort_columns self order:Standard.Base.Data.Sort_Direction.Sort_Direction= text_ordering:Standard.Base.Data.Text.Text_Ordering.Text_Ordering= -> Standard.Database.DB_Table.DB_Table
-    - split_to_columns self column:(Standard.Base.Data.Text.Text|Standard.Base.Data.Numbers.Integer) delimiter:Standard.Base.Data.Text.Text= column_count:Standard.Table.Columns_To_Add.Columns_To_Add= on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior= -> Standard.Database.DB_Table.DB_Table
+    - split_to_columns self column:(Standard.Base.Data.Text.Text|Standard.Base.Data.Numbers.Integer) delimiter:(Standard.Base.Data.Text.Text|Standard.Base.Data.Vector.Vector)= column_count:Standard.Table.Columns_To_Add.Columns_To_Add= on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior= -> Standard.Database.DB_Table.DB_Table
     - split_to_rows self column:(Standard.Base.Data.Text.Text|Standard.Base.Data.Numbers.Integer) delimiter:Standard.Base.Data.Text.Text= -> Standard.Database.DB_Table.DB_Table
     - take self range:(Standard.Base.Data.Index_Sub_Range.Index_Sub_Range|Standard.Base.Data.Range.Range|Standard.Base.Data.Numbers.Integer)= -> Standard.Database.DB_Table.DB_Table
     - text_cleanse self from:(Standard.Base.Data.Vector.Vector Standard.Base.Any.Any) remove:(Standard.Base.Data.Vector.Vector Standard.Base.Data.Text.Regex.Named_Pattern.Named_Pattern)= -> Standard.Database.DB_Table.DB_Table

distribution/lib/Standard/Database/0.0.0-dev/src/DB_Table.enso

@@ -2436,7 +2436,7 @@ type DB_Table
     @column Widget_Helpers.make_column_name_selector
     @delimiter make_delimiter_selector
     @column_count Columns_To_Add.default_widget
-    split_to_columns self (column : Text | Integer) delimiter:Text="," column_count:Columns_To_Add=..All_Columns on_problems:Problem_Behavior=..Report_Warning -> DB_Table =
+    split_to_columns self (column : Text | Integer) delimiter:Text|Vector="," column_count:Columns_To_Add=..All_Columns on_problems:Problem_Behavior=..Report_Warning -> DB_Table =
         _ = [column, delimiter, column_count.columns_to_split, on_problems]
         Error.throw (Unsupported_Database_Operation.Error "split_to_columns")
 

distribution/lib/Standard/Table/0.0.0-dev/docs/api/Table.md

@@ -74,7 +74,7 @@
     - slice self start:Standard.Base.Any.Any end:Standard.Base.Any.Any -> Standard.Base.Any.Any
     - sort self columns:(Standard.Base.Any.Any|Standard.Table.Sort_Column.Sort_Column)= text_ordering:Standard.Base.Data.Text.Text_Ordering.Text_Ordering= error_on_missing_columns:Standard.Base.Data.Boolean.Boolean= on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior= -> Standard.Base.Any.Any
     - sort_columns self order:Standard.Base.Data.Sort_Direction.Sort_Direction= text_ordering:Standard.Base.Data.Text.Text_Ordering.Text_Ordering= -> Standard.Table.Table.Table
-    - split_to_columns self column:(Standard.Base.Data.Text.Text|Standard.Base.Data.Numbers.Integer) delimiter:Standard.Base.Data.Text.Text= column_count:Standard.Table.Columns_To_Add.Columns_To_Add= on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior= -> Standard.Table.Table.Table
+    - split_to_columns self column:(Standard.Base.Data.Text.Text|Standard.Base.Data.Numbers.Integer) delimiter:(Standard.Base.Data.Text.Text|Standard.Base.Data.Vector.Vector)= column_count:Standard.Table.Columns_To_Add.Columns_To_Add= on_problems:Standard.Base.Errors.Problem_Behavior.Problem_Behavior= -> Standard.Table.Table.Table
     - split_to_rows self column:(Standard.Base.Data.Text.Text|Standard.Base.Data.Numbers.Integer) delimiter:Standard.Base.Data.Text.Text= -> Standard.Table.Table.Table
     - table_version_hash self -> Standard.Base.Data.Text.Text
     - take self range:(Standard.Base.Data.Index_Sub_Range.Index_Sub_Range|Standard.Base.Data.Range.Range|Standard.Base.Data.Numbers.Integer)= -> Standard.Table.Table.Table

distribution/lib/Standard/Table/0.0.0-dev/src/Table.enso

@@ -1872,7 +1872,7 @@ type Table
     @column Widget_Helpers.make_column_name_selector
     @delimiter make_delimiter_selector
     @column_count Columns_To_Add.default_widget
-    split_to_columns self (column : Text | Integer) delimiter:Text="," column_count:Columns_To_Add=..All_Columns on_problems:Problem_Behavior=..Report_Warning -> Table =
+    split_to_columns self (column : Text | Integer) delimiter:Text|Vector="," column_count:Columns_To_Add=..All_Columns on_problems:Problem_Behavior=..Report_Warning -> Table =
         Split_Tokenize.split_to_columns self column delimiter column_count=column_count on_problems
 
     ## ALIAS parse, tokenize

test/Table_Tests/src/In_Memory/Split_Tokenize_Spec.enso

@@ -90,6 +90,14 @@ add_specs suite_builder =
             t2 = t.split_to_columns "bar" "|"
             t2.should_equal expected
 
+        group_builder.specify "can do split_to_columns on a vector of newlines" <|
+            cols = [["foo", [0, 1, 2, 3, 4]], ["bar", ['a\nbc', 'cbd\r\nbef', 'ghb\nijbu', Nothing, ""]]]
+            t = Table.new cols
+            expected_rows = [[0, "a", "bc"], [1, "cbd", "bef"], [2, "ghb", "ijbu"], [3, Nothing, Nothing], [4, "", Nothing]]
+            expected = Table.from_rows ["foo", "bar 1", "bar 2"] expected_rows
+            t2 = t.split_to_columns "bar" ['\n', '\r\n', '\r']
+            t2.should_equal expected
+
     suite_builder.group "Table.tokenize" group_builder->
         group_builder.specify "can do tokenize_to_columns" <|
             cols = [["foo", [0, 1, 2]], ["bar", ["a12b34r5", "23", "2r4r55"]]]