Fix renaming for Local assets (#12815)

* Fix renaming for Local assets

* Fix :(

Author: MrFlashAccount

app/gui/src/dashboard/services/LocalBackend.ts

@@ -640,15 +640,39 @@ export default class LocalBackend extends Backend {
     assetId: backend.AssetId,
     body: backend.UpdateAssetRequestBody,
   ): Promise<void> {
-    if (body.parentDirectoryId != null) {
-      const typeAndId = extractTypeAndId(assetId)
-      const from =
-        typeAndId.type !== backend.AssetType.project ?
+    // Changing description is not supported on the Local Backend.
+    const { parentDirectoryId, title } = body
+
+    const typeAndId = extractTypeAndId(assetId)
+
+    const currentParentDirectoryPath = (() => {
+      return typeAndId.type !== backend.AssetType.project ?
           typeAndId.id
         : this.projectManager.getProjectPath(typeAndId.id)
-      const fileName = getFileName(from)
-      const to = joinPath(extractTypeAndId(body.parentDirectoryId).id, fileName)
-      await this.projectManager.moveFile(from, to)
+    })()
+
+    const newParentDirectoryPath = (() => {
+      const fileName = title == null ? getFileName(currentParentDirectoryPath) : title
+
+      if (parentDirectoryId == null) {
+        return joinPath(
+          projectManager.Path(currentParentDirectoryPath.split('/').slice(0, -1).join('/')),
+          fileName,
+        )
+      }
+
+      return joinPath(extractTypeAndId(parentDirectoryId).id, fileName)
+    })()
+
+    await this.projectManager.moveFile(currentParentDirectoryPath, newParentDirectoryPath)
+
+    // Changing the folder name for a project is _not_ enough,
+    // we also need to change the name in the package.yaml file.
+    if (typeAndId.type === backend.AssetType.project && title != null) {
+      await this.projectManager.renameProject({
+        projectId: typeAndId.id,
+        name: projectManager.ProjectName(title),
+      })
     }
   }
 

app/gui/src/dashboard/services/ProjectManager.ts

@@ -620,47 +620,6 @@ export default class ProjectManager {
       '--filesystem-move-to',
       to,
     )
-    const children = this.internalDirectories.get(from)
-    // Assume a directory needs to be loaded for its children to be loaded.
-    if (children) {
-      const moveChildren = (directoryChildren: readonly FileSystemEntry[]) => {
-        for (const child of directoryChildren) {
-          switch (child.type) {
-            case FileSystemEntryType.DirectoryEntry: {
-              const childChildren = this.internalDirectories.get(child.path)
-              if (childChildren) {
-                moveChildren(childChildren)
-              }
-              break
-            }
-            case FileSystemEntryType.ProjectEntry: {
-              const path = this.internalProjectPaths.get(child.metadata.id)
-              if (path != null) {
-                this.internalProjectPaths.set(child.metadata.id, Path(path.replace(from, to)))
-              }
-              break
-            }
-            case FileSystemEntryType.FileEntry: {
-              // No special extra metadata is stored for files.
-              break
-            }
-          }
-        }
-        this.internalDirectories.set(
-          from,
-          children.map((child) => ({ ...child, path: Path(child.path.replace(from, to)) })),
-        )
-      }
-      moveChildren(children)
-    }
-    const directoryPath = getDirectoryAndName(from).directoryPath
-    const siblings = this.internalDirectories.get(directoryPath)
-    if (siblings) {
-      this.internalDirectories.set(
-        directoryPath,
-        siblings.filter((entry) => entry.path !== from),
-      )
-    }
   }
 
   /** Delete a file or directory. */