From 0a1a82f2b3973386d1d7015440d144b28afd2ff4 Mon Sep 17 00:00:00 2001 From: Mahdi Date: Wed, 26 Mar 2025 13:45:22 +0330 Subject: [PATCH 1/2] Use context manager in get_version function for better file handling --- setup.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index f80dcff2cc..c9aeec7d23 100755 --- a/setup.py +++ b/setup.py @@ -43,7 +43,8 @@ def get_version(package): """ Return package version as listed in `__version__` in `init.py`. """ - init_py = open(os.path.join(package, '__init__.py')).read() + with open(os.path.join(package, '__init__.py'), encoding='utf-8') as f: + init_py = f.read() return re.search("__version__ = ['\"]([^'\"]+)['\"]", init_py).group(1) From f0e27463c9445f6b2d7c0d8a33866034befb35af Mon Sep 17 00:00:00 2001 From: Mahdi Date: Wed, 26 Mar 2025 14:09:59 +0330 Subject: [PATCH 2/2] Refactor get_version function to use pathlib for file reading - Replaced open() and os.path.join() with Path.read_text() for simplicity and readability. --- setup.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/setup.py b/setup.py index c9aeec7d23..34382b1fa3 100755 --- a/setup.py +++ b/setup.py @@ -2,6 +2,7 @@ import re import shutil import sys +from pathlib import Path from setuptools import find_packages, setup @@ -35,16 +36,14 @@ def read(f): - with open(f, encoding='utf-8') as file: - return file.read() + return Path(f).read_text(encoding='utf-8') def get_version(package): """ Return package version as listed in `__version__` in `init.py`. """ - with open(os.path.join(package, '__init__.py'), encoding='utf-8') as f: - init_py = f.read() + init_py = Path(package, "__init__.py").read_text(encoding="utf-8") return re.search("__version__ = ['\"]([^'\"]+)['\"]", init_py).group(1)