-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add support for source with attributes in extra_kwargs of ModelSerializer #9077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
dd0bb97
705e277
c1ccc37
a5b239e
2fc08b2
05b2e3b
b4ce3e5
53141ac
d60b909
84fd5ee
5be47e4
5a106a0
af69a58
998025a
f15196a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1117,9 +1117,36 @@ def get_fields(self): | |
if source == '*': | ||
source = field_name | ||
|
||
# Get the right model and info for source with attributes | ||
source_attrs = source.split('.') | ||
source_info = info | ||
source_model = model | ||
|
||
if len(source_attrs) > 1: | ||
attr_info = info | ||
attr_model = model | ||
|
||
for attr in source_attrs[:-1]: | ||
if attr not in attr_info.relations: | ||
break | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to cause trailing attributes to be ignored if they are "after" other relation attributes, but are not a relation themselves. Is this intended? If so, I think this scenario should also have a test case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not really intended. Is it possible to have attributes other than relations with sufficient information in this function to be able to follow them? As far as I know, this isn't the case, so I just did it this way. It's also possible that I misunderstood your comment |
||
|
||
attr_model = attr_info.relations[attr].related_model | ||
attr_info = model_meta.get_field_info(attr_model) | ||
else: | ||
attr = source_attrs[-1] | ||
if ( | ||
attr in attr_info.fields_and_pk | ||
or attr in attr_info.relations | ||
or hasattr(attr_model, attr) | ||
or attr == self.url_field_name | ||
): | ||
source = attr | ||
source_info = attr_info | ||
source_model = attr_model | ||
|
||
# Determine the serializer field class and keyword arguments. | ||
field_class, field_kwargs = self.build_field( | ||
source, info, model, depth | ||
source, source_info, source_model, depth | ||
) | ||
|
||
# Include any kwargs defined in `Meta.extra_kwargs` | ||
|
Uh oh!
There was an error while loading. Please reload this page.