Why is global config inside settings.py is not used?

[hantsaniala]

Hello everyone,

I can't figure out why all values inside settings.py is not used, but instead I must specify all values manually for every ModelViewSet. What I am missing?

Here is my settings.py

INSTALLED_APPS = [
    'django.contrib.admin',
    'django.contrib.auth',
    'django.contrib.contenttypes',
    'django.contrib.sessions',
    'django.contrib.messages',
    'django.contrib.staticfiles',

    "corsheaders",
    "rest_framework",
    'rest_framework.authtoken',
    "rest_framework_simplejwt",
    'rest_framework_simplejwt.token_blacklist',
    "django_filters",
    "drf_yasg",
   
    # ... apps
]

REST_FRAMEWORK = {
    "DEFAULT_PERMISSION_CLASSES": (
        "rest_framework.permissions.IsAuthenticated",
    ),
    "DEFAULT_FILTER_BACKENDS": (
        "django_filters.rest_framework.DjangoFilterBackend",
    ),
    "DEFAULT_AUTHENTICATION_CLASSES": (
        "rest_framework_simplejwt.authentication.JWTAuthentication",
        "rest_framework.authentication.SessionAuthentication",
    ),
    "DEFAULT_SCHEMA_CLASS": "rest_framework.schemas.coreapi.AutoSchema",
    "DEFAULT_PAGINATION_CLASS": "core.utils.StdPagination",
    "PAGE_SIZE": 25,
}

It only works when I specify all config manually for every view.

from rest_framework import viewsets
from rest_framework.permissions import IsAuthenticated
from rest_framework_simplejwt.authentication import JWTAuthentication
from api.utils import StdPagination
from transaction.models import Transaction
from transaction.serializers import TransactionSerializer

class TransactionViewSet(viewsets.ModelViewSet):
    queryset = Transaction.objects.all()
    serializer_class = TransactionSerializer
    
    # All of these class bellow must be set manually to all view to make them work
    permission_classes = [IsAuthenticated]
    authentication_classes = [JWTAuthentication]
    pagination_class = StdPagination

My requirements.txt

django==4.2.4
django-cors-headers==4.2.0
django-filter==23.2
djangorestframework==3.14.0
djangorestframework-simplejwt==5.3.0
drf-yasg==1.21.4
....

Thanks.

[auvipy]

can you please more specific on which are not working or need to be done twice?

[hantsaniala]

Thanks for your reply. I've updated my question, I've put a comment on my view example.

[shakori999]

if you're encountering repetitive configurations and looking to follow the DRY (Don't Repeat Yourself) principle, you can create a custom base viewset class with these common configurations:

from rest_framework import viewsets
from rest_framework.permissions import IsAuthenticated
from rest_framework_simplejwt.authentication import JWTAuthentication
from core.utils import StdPagination  # Make sure to use the correct import path for your StdPagination

class BaseViewSet(viewsets.ModelViewSet):
    """
    This is a custom base viewset class designed to minimize repetition.
    
    It encapsulates common settings such as authentication, permissions, and pagination.
    By inheriting from this base viewset in your specific viewsets, you eliminate
    the need to manually specify these attributes for each view.
    """
    permission_classes = [IsAuthenticated]
    authentication_classes = [JWTAuthentication]
    pagination_class = StdPagination

class YourViewSet(BaseViewSet):
    """
    This is a specific viewset for your model, inheriting from the BaseViewSet.
    
    Here, you only need to define model-specific attributes like 'queryset' and 'serializer_class'.
    This approach adheres to the DRY principle and maintains a consistent configuration
    across your views.
    """
    queryset = YourModel.objects.all()
    serializer_class = YourModelSerializer  # Replace with your serializer class

By adopting this approach, you make your code cleaner, more maintainable, and less error.
I hope it will helps you for now!

[hantsaniala]

Thanks a lot for your suggestion. I'll stick with it. But, it's just a workaround to fix the problem and to avoid DRY, but it still doesn't answer why putting the configuration inside settings.py doesn't work.