Skip to content

Commit 7978a62

Browse files
authored
Pass -DENABLE_WERROR=0 when building Binaryen (#1028)
* Pass -DENABLE_WERROR=0 when building Binaryen We are experiencing an issue at our Unity CI with building Binaryen: WebAssembly/binaryen#4588 It seems that for end users, disabling -Werror is a good general measure to enable wider chance of success to build. Emsdk installations are unlikely to be used by Binaryen developers to iterate on Binaryen development, so it is not necessary there? * Flake
1 parent c2147f3 commit 7978a62

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

emsdk.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1543,7 +1543,7 @@ def build_binaryen_tool(tool):
15431543
build_type = decide_cmake_build_type(tool)
15441544

15451545
# Configure
1546-
args = []
1546+
args = ['-DENABLE_WERROR=0'] # -Werror is not useful for end users
15471547

15481548
cmake_generator = CMAKE_GENERATOR
15491549
if 'Visual Studio 16' in CMAKE_GENERATOR: # VS2019

0 commit comments

Comments
 (0)