Skip to content

Commit 6305e91

Browse files
authored
Improve ordering in emsdk list (#1180)
We have an existing `version_key` helper function for sorting versions. It also does a better job, producing output like: ``` All recent (non-legacy) installable versions are: 3.1.31 3.1.31-asserts 3.1.30 3.1.30-asserts 3.1.29 3.1.29-asserts ``` Rather than: ``` All recent (non-legacy) installable versions are: 3.1.31 3.1.30 3.1.29 3.1.28 3.1.27 ``` (with -assert versions listed after 3.1.0)
1 parent c678733 commit 6305e91

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

emsdk.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2845,11 +2845,7 @@ def installed_sdk_text(name):
28452845
print('')
28462846

28472847
print('All recent (non-legacy) installable versions are:')
2848-
releases_versions = sorted(
2849-
load_releases_versions(),
2850-
key=lambda x: [int(v) if v.isdigit() else -1 for v in x.split('.')],
2851-
reverse=True,
2852-
)
2848+
releases_versions = sorted(load_releases_versions(), key=version_key, reverse=True)
28532849
releases_info = load_releases_info()['releases']
28542850
for ver in releases_versions:
28552851
print(' %s %s' % (ver, installed_sdk_text('sdk-releases-%s-64bit' % get_release_hash(ver, releases_info))))

0 commit comments

Comments
 (0)