Skip to content

Commit 497595e

Browse files
authored
Fix macOS build (#996)
* Fix macOS build. See WebAssembly/binaryen#4299 * Update comment
1 parent 637777b commit 497595e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

emsdk.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,16 +1033,16 @@ def cmake_configure(generator, build_root, src_root, build_type, extra_cmake_arg
10331033
generator = []
10341034

10351035
cmdline = ['cmake'] + generator + ['-DCMAKE_BUILD_TYPE=' + build_type, '-DPYTHON_EXECUTABLE=' + sys.executable]
1036-
# Target macOS 10.11 at minimum, to support widest range of Mac devices from "Mid 2007" and newer:
1037-
# https://en.wikipedia.org/wiki/MacBook_Pro#Supported_macOS_releases
1038-
cmdline += ['-DCMAKE_OSX_DEPLOYMENT_TARGET=10.11']
1036+
# Target macOS 10.14 at minimum, to support widest range of Mac devices from "Early 2008" and newer:
1037+
# https://en.wikipedia.org/wiki/MacBook_(2006–2012)#Supported_operating_systems
1038+
cmdline += ['-DCMAKE_OSX_DEPLOYMENT_TARGET=10.14']
10391039
cmdline += extra_cmake_args + [src_root]
10401040

10411041
print('Running CMake: ' + str(cmdline))
10421042

10431043
# Specify the deployment target also as an env. var, since some Xcode versions
10441044
# read this instead of the CMake field.
1045-
os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.11'
1045+
os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.14'
10461046

10471047
def quote_parens(x):
10481048
if ' ' in x:

0 commit comments

Comments
 (0)