Skip to content

Commit 1b1f5f2

Browse files
authored
Remove unused codepath for single-file tools. NFC (#1013)
We don't have any tools that are just one file, and indeed we assume these days that tools install to their own directory.
1 parent 2a68987 commit 1b1f5f2

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

emsdk.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1968,11 +1968,7 @@ def install_tool(self):
19681968
elif url.endswith(ARCHIVE_SUFFIXES):
19691969
success = download_and_unzip(url, self.installation_path(), filename_prefix=getattr(self, 'zipfile_prefix', ''))
19701970
else:
1971-
dst_file = download_file(urljoin(emsdk_packages_url, self.download_url()), self.installation_path())
1972-
if dst_file:
1973-
success = True
1974-
else:
1975-
success = False
1971+
assert False
19761972

19771973
if not success:
19781974
exit_with_error("installation failed!")
@@ -2017,7 +2013,7 @@ def install_tool(self):
20172013

20182014
def cleanup_temp_install_files(self):
20192015
if KEEP_DOWNLOADS:
2020-
return
2016+
return
20212017
url = self.download_url()
20222018
if url.endswith(ARCHIVE_SUFFIXES):
20232019
download_target = get_download_target(url, zips_subdir, getattr(self, 'zipfile_prefix', ''))

0 commit comments

Comments
 (0)