You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use normal JS library aliases for GL symbols. NFC (#19033)
The `recordGLProcAddressGet` helper was attempt to resolve and
create aliases using `copyLibEntry`, but this function doesn't work
when the target of the alias exists in a different library file.
This was resulting `undefined` being set for these aliases and the
resulting JS code would contains, for example:
```
var glGenFramebuffersOES = undefined;
```
Completely removing the aliasing resolution and the symbol copying
from `recordGLProcAddressGet` seems to do the right thing, and should
save on code size too:
```
var _glGenFramebuffersOES = _glGenFramebuffers;
```
// GL proc address retrieval - allow access through glX and emscripten_glX, to allow name collisions with user-implemented things having the same name (see gl.c)
4224
+
// GL proc address retrieval - allow access through glX and emscripten_glX, to
4225
+
// allow name collisions with user-implemented things having the same name
4226
+
// (see gl.c)
4233
4227
Object.keys(lib).forEach((x)=>{
4234
-
if(isJsLibraryConfigIdentifier(x))return;
4235
-
if(x.substr(0,2)!='gl')return;
4236
-
while(typeoflib[x]=='string'){
4237
-
// resolve aliases right here, simpler for fastcomp
0 commit comments