Skip to content

Commit f87d4ab

Browse files
authored
Temporarily set -Wno-pointer-sign for zlib build (#16906)
zlib's configure script assumes that test compiles failed if there is any output on stderr (rather than being based on exit status). Sometimes emscripten prints "building libc" or similar if it needs to build a library. This causes flaky failures in running the tests. See #16908 for details. This PR works around the problem by disabling the warning, but doesn't fix the underlying problem.
1 parent b8bdd3b commit f87d4ab

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tests/common.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1243,6 +1243,9 @@ def get_zlib_library(self, cmake):
12431243
self.emcc_args.append('-Wno-shift-negative-value')
12441244
# adler32.c uses K&R sytyle function declarations
12451245
self.emcc_args.append('-Wno-deprecated-non-prototype')
1246+
# Work around configure-script error. TODO: remove when
1247+
# https://github.com/emscripten-core/emscripten/issues/16908 is fixed
1248+
self.emcc_args.append('-Wno-pointer-sign')
12461249
if cmake:
12471250
rtn = self.get_library(os.path.join('third_party', 'zlib'), os.path.join('libz.a'),
12481251
configure=['cmake', '.'],

0 commit comments

Comments
 (0)